diff options
| author | Volker Lendecke <vl@samba.org> | 2016-12-31 12:45:51 +0000 |
|---|---|---|
| committer | Ralph Boehme <slow@samba.org> | 2017-01-03 16:04:29 +0100 |
| commit | b3d5fe9679a56ba20e9627fecda36c60a471a20c (patch) | |
| tree | 80ca7d4e56d26ab78d79da459a276733ca4302f7 /source4/torture/rpc | |
| parent | 6eeb3ec3ab19ddee11829f1d5ac2d13ef1c7b18c (diff) | |
| download | samba-b3d5fe9679a56ba20e9627fecda36c60a471a20c.tar.gz | |
torture-samlogon: Use "all_zero" where appropriate
... Saves a few bytes of footprint
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Diffstat (limited to 'source4/torture/rpc')
| -rw-r--r-- | source4/torture/rpc/samlogon.c | 13 |
1 files changed, 3 insertions, 10 deletions
diff --git a/source4/torture/rpc/samlogon.c b/source4/torture/rpc/samlogon.c index cefc4f59d06..bd42ec98085 100644 --- a/source4/torture/rpc/samlogon.c +++ b/source4/torture/rpc/samlogon.c @@ -921,14 +921,11 @@ static bool test_lmv2_ntlm_broken(struct samlogon_state *samlogon_state, pass = false; } } else { - static const uint8_t zeros[8]; - if (memcmp(zeros, lm_session_key, - sizeof(lm_session_key)) != 0) { + if (!all_zero(lm_session_key, + sizeof(lm_session_key))) { torture_comment(samlogon_state->tctx, "LM Session Key does not match expectations (zeros)!\n"); torture_comment(samlogon_state->tctx, "lm_session_key:\n"); dump_data(1, lm_session_key, 8); - torture_comment(samlogon_state->tctx, "expected:\n"); - dump_data(1, zeros, 8); pass = false; } } @@ -1176,14 +1173,10 @@ static bool test_ntlm2(struct samlogon_state *samlogon_state, char **error_strin pass = false; } } else { - static const uint8_t zeros[8]; - if (memcmp(zeros, lm_key, - sizeof(lm_key)) != 0) { + if (!all_zero(lm_key, sizeof(lm_key))) { torture_comment(samlogon_state->tctx, "LM Session Key does not match expectations (zeros)!\n"); torture_comment(samlogon_state->tctx, "lm_key:\n"); dump_data(1, lm_key, 8); - torture_comment(samlogon_state->tctx, "expected:\n"); - dump_data(1, zeros, 8); pass = false; } } |