diff options
| author | Andrew Tridgell <tridge@samba.org> | 2005-10-12 11:04:01 +0000 |
|---|---|---|
| committer | Gerald (Jerry) Carter <jerry@samba.org> | 2007-10-10 13:39:43 -0500 |
| commit | f308cc1616b1eb504368fbd7a8aac76333869e3c (patch) | |
| tree | 675cfe67bdae0bf0e18f71765199a7e9c2afa26c /source4/smbd/process_single.c | |
| parent | 2e61cce2b43570245825c3bdb9ee526fcbbceb6c (diff) | |
| download | samba-f308cc1616b1eb504368fbd7a8aac76333869e3c.tar.gz | |
r10920: in case of a accept() failure just failing and trying again is no
good, as it is probably a resource constraint, so if we just try again
we will spin (as the incoming socket will still be readable). Using a
sleep(1) solves this by throtting smbd until the resource constraint
goes away.
if the resource constraint doesn't go away, then at least smbd won't
be spinning chewing cpu
(This used to be commit 7a5a9da477186b5e4fdb34ec64cc97915de4fd8e)
Diffstat (limited to 'source4/smbd/process_single.c')
| -rw-r--r-- | source4/smbd/process_single.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/source4/smbd/process_single.c b/source4/smbd/process_single.c index 56b074a6294..8c9dd2f7fa7 100644 --- a/source4/smbd/process_single.c +++ b/source4/smbd/process_single.c @@ -26,6 +26,7 @@ #include "lib/events/events.h" #include "dlinklist.h" #include "smb_server/smb_server.h" +#include "system/filesys.h" /* @@ -51,6 +52,13 @@ static void single_accept_connection(struct event_context *ev, status = socket_accept(sock, &sock2); if (!NT_STATUS_IS_OK(status)) { DEBUG(0,("accept_connection_single: accept: %s\n", nt_errstr(status))); + /* this looks strange, but is correct. We need to + throttle things until the system clears enough + resources to handle this new socket. If we don't + then we will spin filling the log and causing more + problems. We don't panic as this is probably a + temporary resource constraint */ + sleep(1); return; } |