diff options
| author | Andrew Bartlett <abartlet@samba.org> | 2019-11-11 15:02:30 +1300 |
|---|---|---|
| committer | Andrew Bartlett <abartlet@samba.org> | 2019-11-20 02:14:56 +0000 |
| commit | 1af1ebe54aefd436b6ed80cb99a30282d5abd495 (patch) | |
| tree | 3842211bcdf80098976ced687d8c027123014644 /source4/rpc_server | |
| parent | 7ae46019df1c5369cfd15f99448b94e425eddcc4 (diff) | |
| download | samba-1af1ebe54aefd436b6ed80cb99a30282d5abd495.tar.gz | |
librpc: Unify packet dumping on ndr_pull() failure
There were two duplicate implementations of packet dumping just for the s4 RPC server!
This unifies them and makes them easier to find because they are not triggered
from the generated server stub any more.
The behaviour have unified on setting "dcesrv:stubs directory" and
being compiled with --enable-developer.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Samuel Cabrero <scabrero@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Nov 20 02:14:56 UTC 2019 on sn-devel-184
Diffstat (limited to 'source4/rpc_server')
| -rw-r--r-- | source4/rpc_server/remote/dcesrv_remote.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/source4/rpc_server/remote/dcesrv_remote.c b/source4/rpc_server/remote/dcesrv_remote.c index 916e59e5f4b..8de9190e03e 100644 --- a/source4/rpc_server/remote/dcesrv_remote.c +++ b/source4/rpc_server/remote/dcesrv_remote.c @@ -277,9 +277,6 @@ static NTSTATUS remote_op_ndr_pull(struct dcesrv_call_state *dce_call, TALLOC_CT /* unravel the NDR for the packet */ ndr_err = table->calls[opnum].ndr_pull(pull, NDR_IN, *r); if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) { - dcerpc_log_packet(dce_call->conn->packet_log_dir, - table, opnum, NDR_IN, - &dce_call->pkt.u.request.stub_and_verifier); dce_call->fault_code = DCERPC_FAULT_NDR; return NT_STATUS_NET_WRITE_FAULT; } |