s4/param: treat NULL value passed to dict_insert as error

insert_dict is used as a convenience to decrement the values to
prevent leaks with orpahaned PyObjects and avoid excessive creation of
temp variables.

        if (!dict_insert(parameters,
                         "rootdn",
                         PyUnicode_FromString(settings->root_dn_str))) {
                status = NT_STATUS_UNSUCCESSFUL;
                goto out;
        }

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

1 files changed, 3 insertions, 0 deletions

diff --git a/source4/param/provision.c b/source4/param/provision.c
index 60ce07384f8..5cf38c66dd2 100644
--- a/source4/param/provision.c
+++ b/source4/param/provision.c
@@ -35,6 +35,9 @@ static bool dict_insert(PyObject* dict,
 			const char* key,
 			PyObject* value)
 {
+	if (value == NULL) {
+		return false;
+	}
 	if (PyDict_SetItemString(dict, key, value) == -1) {
 		Py_XDECREF(value);
 		return false;