summaryrefslogtreecommitdiff
path: root/source4/kdc/kpasswd-helper.c
diff options
context:
space:
mode:
authorAndreas Schneider <asn@samba.org>2016-09-13 10:25:07 +0200
committerJeremy Allison <jra@samba.org>2016-09-13 22:13:31 +0200
commit8267ec209a6c588f48e6e8d37d4d7a9cae7a2cb3 (patch)
treeb109b20688b90bbc5bc93d673dd2d076acf63d1e /source4/kdc/kpasswd-helper.c
parent7a0ff3bc261f6f8aad87366862f884e344603bef (diff)
downloadsamba-8267ec209a6c588f48e6e8d37d4d7a9cae7a2cb3.tar.gz
s4-kdc: Do not leak memory on error in kpasswd_make_error_reply()
CID 1372874 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Tue Sep 13 22:13:31 CEST 2016 on sn-devel-144
Diffstat (limited to 'source4/kdc/kpasswd-helper.c')
-rw-r--r--source4/kdc/kpasswd-helper.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/source4/kdc/kpasswd-helper.c b/source4/kdc/kpasswd-helper.c
index 996b318bd40..6de28375cba 100644
--- a/source4/kdc/kpasswd-helper.c
+++ b/source4/kdc/kpasswd-helper.c
@@ -54,11 +54,13 @@ bool kpasswd_make_error_reply(TALLOC_CTX *mem_ctx,
*/
#ifndef SAMBA4_USES_HEIMDAL
if (slen < 2) {
+ talloc_free(s);
return false;
}
slen -= 2;
#endif
if (2 + slen < slen) {
+ talloc_free(s);
return false;
}
error_data->length = 2 + slen;