summaryrefslogtreecommitdiff
path: root/source4/heimdal_build
diff options
context:
space:
mode:
authorAndrew Bartlett <abartlet@samba.org>2013-05-26 23:11:03 +1000
committerAndrew Bartlett <abartlet@samba.org>2013-05-27 11:56:46 +1000
commitc6673b96a59e38031da6654580250bbc58766cfd (patch)
tree3cb5f919f7bcde8f9cd21a38e66aa25432baedf5 /source4/heimdal_build
parentdfe73e7885a40de8c24d1231365a16f7aa3d5073 (diff)
downloadsamba-c6673b96a59e38031da6654580250bbc58766cfd.tar.gz
build: Remove binaries and libraries build groups
Build groups are used in Samba to ensure that even if the dependency chain for a target is not perfect, that it builds reliably. This matters most in the early build stages, where we are building the asn1 compiler and autogenerating files. Once we get to the main stage, dependencies between C files, libraries and binaries are much clearer, because the C compiler and linker takes these as inputs anyway. Groups were added to our waf build for stability during early development, as dependency information was first imported from the previous autoconf/perl based build system. I don't think we need this distinction in the main build of C files into .o, and when linking these into binaries, because the invocation of these tools is very well defined, and we will find any missing inputs very quickly. As such, I've removed the libraries and binaries targets, consolidating them with 'main' By making this change, a build of smbtorture only on a clean tree drops from 3778 to 2489 targets, and much of the expensive linker stage is skipped. The time for a null build of smbtorture only also drops from 4.673s to as low as 2.499s on my laptop. Andrew Bartlett Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Diffstat (limited to 'source4/heimdal_build')
-rw-r--r--source4/heimdal_build/wscript_build4
1 files changed, 2 insertions, 2 deletions
diff --git a/source4/heimdal_build/wscript_build b/source4/heimdal_build/wscript_build
index f4471159eb0..44634b4d838 100644
--- a/source4/heimdal_build/wscript_build
+++ b/source4/heimdal_build/wscript_build
@@ -243,7 +243,7 @@ def HEIMDAL_LIBRARY(libname, source, deps, vnum, version_script, includes=''):
features = 'cc cshlib symlink_lib install_lib'
- bld.set_group('libraries')
+ bld.set_group('main')
t = bld(
features = features,
source = [],
@@ -298,7 +298,7 @@ def HEIMDAL_BINARY(binname, source,
use_hostcc=False,
use_global_deps=True,
compiler=None,
- group='binaries',
+ group='main',
install=True,
install_path=None):
'''define a Samba binary'''