summaryrefslogtreecommitdiff
path: root/source4/dsdb
diff options
context:
space:
mode:
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>2017-10-25 12:17:05 +1300
committerAndrew Bartlett <abartlet@samba.org>2017-10-26 01:32:14 +0200
commitb6294c84a53dea5ac13c4ef72017483254739271 (patch)
tree881adbb1edbeeab92c98e6aa3d0ea86503f41891 /source4/dsdb
parent7cf3bbcc5ce9f22e0140fab051b1fe850cf0161d (diff)
downloadsamba-b6294c84a53dea5ac13c4ef72017483254739271.tar.gz
linked attribute tests: fix logic for add test
We were ensuring that when we got an LdbError it was the right type, but we weren't ensuring we got one at all. The new test doesn't fail. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Diffstat (limited to 'source4/dsdb')
-rw-r--r--source4/dsdb/tests/python/linked_attributes.py2
1 files changed, 2 insertions, 0 deletions
diff --git a/source4/dsdb/tests/python/linked_attributes.py b/source4/dsdb/tests/python/linked_attributes.py
index f0c260564bf..1923f687749 100644
--- a/source4/dsdb/tests/python/linked_attributes.py
+++ b/source4/dsdb/tests/python/linked_attributes.py
@@ -401,6 +401,8 @@ class LATests(samba.tests.TestCase):
self.fail("adding duplicate values, expected "
"ERR_ENTRY_ALREADY_EXISTS, (%d) "
"got %d" % (ldb.ERR_ENTRY_ALREADY_EXISTS, num))
+ else:
+ self.fail("adding duplicate values succeed when it shouldn't")
self.assert_forward_links(g1, [u1, u2, u3, u4])
self.assert_forward_links(g2, [u3, u1])