summaryrefslogtreecommitdiff
path: root/source4/dns_server/dns_update.c
diff options
context:
space:
mode:
authorKai Blin <kai@samba.org>2011-12-16 14:25:57 +0100
committerKai Blin <kai@samba.org>2011-12-17 04:19:40 +0100
commitb1fdf4065e4569e58ffceb44e9f4105fa1f8740e (patch)
tree22581427e87316d00b3377fed09c6dd296cedaec /source4/dns_server/dns_update.c
parentafa98bdc51c635cb7d7cc8c63497598e522610fd (diff)
downloadsamba-b1fdf4065e4569e58ffceb44e9f4105fa1f8740e.tar.gz
s4 dns: Allow updates based on smb.conf setting
Autobuild-User: Kai Blin <kai@samba.org> Autobuild-Date: Sat Dec 17 04:19:40 CET 2011 on sn-devel-104
Diffstat (limited to 'source4/dns_server/dns_update.c')
-rw-r--r--source4/dns_server/dns_update.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/source4/dns_server/dns_update.c b/source4/dns_server/dns_update.c
index ccbeed9ff85..3fd612cfabc 100644
--- a/source4/dns_server/dns_update.c
+++ b/source4/dns_server/dns_update.c
@@ -25,9 +25,12 @@
#include "librpc/gen_ndr/ndr_dns.h"
#include "librpc/gen_ndr/ndr_dnsp.h"
#include <ldb.h>
+#include "param/param.h"
#include "dsdb/samdb/samdb.h"
#include "dsdb/common/util.h"
+#include "smbd/service_task.h"
#include "dns_server/dns_server.h"
+#include "dns_server/dns_update.h"
static WERROR dns_rr_to_dnsp(TALLOC_CTX *mem_ctx,
const struct dns_res_rec *rrec,
@@ -653,7 +656,6 @@ WERROR dns_server_process_update(struct dns_server *dns,
const struct dns_server_zone *z;
size_t host_part_len = 0;
WERROR werror = DNS_ERR(NOT_IMPLEMENTED);
- bool update_allowed = false;
if (in->qdcount != 1) {
return DNS_ERR(FORMAT_ERROR);
@@ -701,7 +703,7 @@ WERROR dns_server_process_update(struct dns_server *dns,
/* TODO: Check if update is allowed, we probably want "always",
* key-based GSSAPI, key-based bind-style TSIG and "never" as
* smb.conf options. */
- if (!update_allowed) {
+ if (lpcfg_allow_dns_updates(dns->task->lp_ctx) != DNS_UPDATE_ON) {
DEBUG(0, ("Update not allowed."));
return DNS_ERR(REFUSED);
}