diff options
| author | Ralph Boehme <slow@samba.org> | 2016-05-14 19:08:51 +0200 |
|---|---|---|
| committer | Garming Sam <garming@samba.org> | 2016-06-16 00:06:27 +0200 |
| commit | bea4aec521576576b8dc55065f11c6c5025d9c4f (patch) | |
| tree | 7512c366ca2270f53b8d59af87b67d64c7765473 /source4/dns_server/dns_crypto.c | |
| parent | a51f9989564c28aeece50b56a59e9bb60d41340b (diff) | |
| download | samba-bea4aec521576576b8dc55065f11c6c5025d9c4f.tar.gz | |
librpc/dns: remove original_id from dns_fake_tsig_rec
Cf RFC2845, 3.4.2. "TSIG Variables", the request id (original_id) is not
used in the MAC calculation. This also explains the mysterious 2 bytes
padding.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11520
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Diffstat (limited to 'source4/dns_server/dns_crypto.c')
| -rw-r--r-- | source4/dns_server/dns_crypto.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/source4/dns_server/dns_crypto.c b/source4/dns_server/dns_crypto.c index 3f199de3344..502887fec88 100644 --- a/source4/dns_server/dns_crypto.c +++ b/source4/dns_server/dns_crypto.c @@ -207,9 +207,6 @@ WERROR dns_verify_tsig(struct dns_server *dns, return WERR_NOMEM; } - /*FIXME: Why is there too much padding? */ - buffer_len -= 2; - /* Now we also need to count down the additional record counter */ arcount = RSVAL(buffer, 10); RSSVAL(buffer, 10, arcount-1); |