diff options
| author | Volker Lendecke <vl@samba.org> | 2016-01-07 21:17:43 +0100 |
|---|---|---|
| committer | Jeremy Allison <jra@samba.org> | 2016-01-08 02:37:18 +0100 |
| commit | fc4c2dcd526851fa938f6d8edb15b58fbb644a45 (patch) | |
| tree | d79bbd649df9cd1fd10a9a0e3e6ceef7f9c87694 /source4/dns_server/dlz_bind9.c | |
| parent | 0cb8b9d113b322f784100365669d2be8b7fa635a (diff) | |
| download | samba-fc4c2dcd526851fa938f6d8edb15b58fbb644a45.tar.gz | |
bind_dlz: Fix CID 1347318 Unchecked return value
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Diffstat (limited to 'source4/dns_server/dlz_bind9.c')
| -rw-r--r-- | source4/dns_server/dlz_bind9.c | 16 |
1 files changed, 13 insertions, 3 deletions
diff --git a/source4/dns_server/dlz_bind9.c b/source4/dns_server/dlz_bind9.c index 7a76fe57962..4c21a5ee79d 100644 --- a/source4/dns_server/dlz_bind9.c +++ b/source4/dns_server/dlz_bind9.c @@ -1438,10 +1438,20 @@ static bool b9_record_match(struct dlz_bind9_data *state, switch (rec1->wType) { case DNS_TYPE_A: return strcmp(rec1->data.ipv4, rec2->data.ipv4) == 0; - case DNS_TYPE_AAAA: - inet_pton(AF_INET6, rec1->data.ipv6, &rec1_in_addr6); - inet_pton(AF_INET6, rec2->data.ipv6, &rec2_in_addr6); + case DNS_TYPE_AAAA: { + int ret; + + ret = inet_pton(AF_INET6, rec1->data.ipv6, &rec1_in_addr6); + if (ret != 1) { + return false; + } + ret = inet_pton(AF_INET6, rec2->data.ipv6, &rec2_in_addr6); + if (ret != 1) { + return false; + } + return memcmp(&rec1_in_addr6, &rec2_in_addr6, sizeof(rec1_in_addr6)) == 0; + } case DNS_TYPE_CNAME: return dns_name_equal(rec1->data.cname, rec2->data.cname); case DNS_TYPE_TXT: |