summaryrefslogtreecommitdiff
path: root/source3
diff options
context:
space:
mode:
authorVolker Lendecke <vl@samba.org>2017-04-06 11:35:23 +0200
committerDavid Disseldorp <ddiss@samba.org>2017-04-06 19:31:24 +0200
commit415d61eebbfe22a243bc14c089b01054373cdf7e (patch)
tree7c21f80e113fedde171894bfcc2a7d521e3faf53 /source3
parent7f714a436250dfeaa1970f78090ef066482711f0 (diff)
downloadsamba-415d61eebbfe22a243bc14c089b01054373cdf7e.tar.gz
idmap_ldap: Fix CID 1404836 Dereference before null check
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org> Autobuild-User(master): David Disseldorp <ddiss@samba.org> Autobuild-Date(master): Thu Apr 6 19:31:25 CEST 2017 on sn-devel-144
Diffstat (limited to 'source3')
-rw-r--r--source3/winbindd/idmap_ldap.c11
1 files changed, 1 insertions, 10 deletions
diff --git a/source3/winbindd/idmap_ldap.c b/source3/winbindd/idmap_ldap.c
index 041152cc1fb..75450618082 100644
--- a/source3/winbindd/idmap_ldap.c
+++ b/source3/winbindd/idmap_ldap.c
@@ -78,16 +78,7 @@ static NTSTATUS get_credentials( TALLOC_CTX *mem_ctx,
tmp = idmap_config_const_string(dom->name, "ldap_user_dn", NULL);
if ( tmp ) {
- if (!dom) {
- DEBUG(0, ("get_credentials: Invalid domain 'NULL' "
- "encountered for user DN %s\n",
- tmp));
- ret = NT_STATUS_UNSUCCESSFUL;
- goto done;
- } else {
- secret = idmap_fetch_secret("ldap", dom->name, tmp);
- }
-
+ secret = idmap_fetch_secret("ldap", dom->name, tmp);
if (!secret) {
DEBUG(0, ("get_credentials: Unable to fetch "
"auth credentials for %s in %s\n",