diff options
| author | Günther Deschner <gd@samba.org> | 2018-05-08 13:46:11 +0200 |
|---|---|---|
| committer | Karolin Seeger <kseeger@samba.org> | 2018-06-20 09:22:24 +0200 |
| commit | 1b420a212e38760d801449932d1905cd74f98979 (patch) | |
| tree | 833a518d10245cc9f8f2ff726dd3446ffca427b0 /source3 | |
| parent | 35de20bd3c7f5f4e73dda5070da05b0d081c3090 (diff) | |
| download | samba-1b420a212e38760d801449932d1905cd74f98979.tar.gz | |
s3-printing: fix format-truncation in print_queue_update()
../source3/printing/printing.c: In function ‘print_queue_update’:
../source3/printing/printing.c:1809:42: error: ‘%s’ directive output may be truncated writing up to 255 bytes into a region of size 244 [-Werror=format-truncation=]
snprintf(key, sizeof(key), "MSG_PENDING/%s", sharename);
^~ ~~~~~~~~~
../source3/printing/printing.c:1809:2: note: ‘snprintf’ output between 13 and 268 bytes into a destination of size 256
snprintf(key, sizeof(key), "MSG_PENDING/%s", sharename);
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13437
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 6326b3415f3e225aafd5912d0965c80abcd7b22c)
Diffstat (limited to 'source3')
| -rw-r--r-- | source3/printing/printing.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/source3/printing/printing.c b/source3/printing/printing.c index e4bb1d84f69..38d718045a1 100644 --- a/source3/printing/printing.c +++ b/source3/printing/printing.c @@ -1693,7 +1693,7 @@ extern pid_t background_lpq_updater_pid; static void print_queue_update(struct messaging_context *msg_ctx, int snum, bool force) { - fstring key; + char key[268]; fstring sharename; char *lpqcommand = NULL; char *lprmcommand = NULL; |