diff options
| author | Marc VanHeyningen <marc.vanheyningen@isilon.com> | 2009-05-05 22:07:40 +0000 |
|---|---|---|
| committer | Karolin Seeger <kseeger@samba.org> | 2009-05-29 09:34:44 +0200 |
| commit | ae42622ae88b286350d7333723e5878b1b22898e (patch) | |
| tree | 00e5ae2fdf1e49fd54cde00efaf5f600dad81520 /source3 | |
| parent | 6f3a58dce40c7acd21f405e6eaf57e5c660a6678 (diff) | |
| download | samba-ae42622ae88b286350d7333723e5878b1b22898e.tar.gz | |
s3: zero an uninitialized array
Invalid pointers were being dereferenced in lookup_sids causing
occasional seg faults.
Signed-off-by: Tim Prouty <tprouty@samba.org>
(cherry picked from commit 5afacc0a65e52e73e3887545c4e5e1ad44264b66)
Diffstat (limited to 'source3')
| -rw-r--r-- | source3/passdb/lookup_sid.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/source3/passdb/lookup_sid.c b/source3/passdb/lookup_sid.c index b45000e77ed..3a03cfe081d 100644 --- a/source3/passdb/lookup_sid.c +++ b/source3/passdb/lookup_sid.c @@ -468,12 +468,15 @@ static bool lookup_rids(TALLOC_CTX *mem_ctx, const DOM_SID *domain_sid, sid_string_dbg(domain_sid))); if (num_rids) { - *names = TALLOC_ARRAY(mem_ctx, const char *, num_rids); + *names = TALLOC_ZERO_ARRAY(mem_ctx, const char *, num_rids); *types = TALLOC_ARRAY(mem_ctx, enum lsa_SidType, num_rids); if ((*names == NULL) || (*types == NULL)) { return false; } + + for (i = 0; i < num_rids; i++) + (*types)[i] = SID_NAME_UNKNOWN; } else { *names = NULL; *types = NULL; |