diff options
| author | Ralph Boehme <slow@samba.org> | 2018-05-01 09:53:36 +0200 |
|---|---|---|
| committer | Karolin Seeger <kseeger@samba.org> | 2018-05-14 09:58:07 +0200 |
| commit | 1b34b8691896dcfac6be604fdd354c2b2466efb8 (patch) | |
| tree | b1809d707afbc32c343e6f1e2f5f50f0138bcf17 /source3 | |
| parent | bb5cee36b67ca78d29474f6f33fab9372203b925 (diff) | |
| download | samba-1b34b8691896dcfac6be604fdd354c2b2466efb8.tar.gz | |
s3:cleanupd: sends MSG_SMB_UNLOCK twice to interested peers
MSG_SMB_UNLOCK should be send to smbd that are waiting on blocked
byte-range-locks when a lock holder died.
In smbd_cleanupd_unlock() we do this twice: once via a broadcast and
then again via brl_revalidate() to processes that are actually recorded
in brlock.tdb.
As brl_revalidate() should already take care of signaling anyone who
would be interested in the message, there's no need to broadcast.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13416
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri May 4 03:02:28 CEST 2018 on sn-devel-144
(cherry picked from commit 53ff08a2cf838c0f1c3f050ac2aa13fc3acc5981)
Diffstat (limited to 'source3')
| -rw-r--r-- | source3/smbd/smbd_cleanupd.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/source3/smbd/smbd_cleanupd.c b/source3/smbd/smbd_cleanupd.c index a9b1e8a1137..6ed87207925 100644 --- a/source3/smbd/smbd_cleanupd.c +++ b/source3/smbd/smbd_cleanupd.c @@ -98,8 +98,6 @@ static void smbd_cleanupd_unlock(struct messaging_context *msg, DBG_WARNING("Cleaning up brl and lock database after unclean " "shutdown\n"); - messaging_send_all(msg, MSG_SMB_UNLOCK, NULL, 0); - brl_revalidate(msg, private_data, msg_type, server_id, data); } |