diff options
| author | Jones Syue <jonessyue@qnap.com> | 2023-01-11 16:59:42 +0800 |
|---|---|---|
| committer | Volker Lendecke <vl@samba.org> | 2023-01-11 17:08:10 +0000 |
| commit | de5d31f452b2445bd92b1746efb05aa096716af8 (patch) | |
| tree | fce3952f02a56831edd26a8e7597219b09122e34 /source3 | |
| parent | 7ffa732d8280c2e88daab6c3b97de71a3cdfb3ba (diff) | |
| download | samba-de5d31f452b2445bd92b1746efb05aa096716af8.tar.gz | |
s3:smbstatus: go to cmdline_messaging_context_free
If the locking.tdb is not found,
(for example, fresh new installed samba server is not running yet)
smbstatus utility would exit earlier,
and lock files are left behind in the directory 'msg.sock' and 'msg.lock'.
Consider that a script to run smbstatus utility in a loop,
this might result in used space slowly growing-up on the underlying filesystem.
Since the samba server is not running yet,
there is no cleanupd daemon could delete these files to reclaim space.
Supposed to use 'ret = 0; goto done;' instead of exit(0),
this would go through the cmdline_messaging_context_free() which deletes
the lock files in the directory msg.sock and msg.lock before smbstatus
utility is exiting.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15282
Signed-off-by: Jones Syue <jonessyue@qnap.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Wed Jan 11 17:08:10 UTC 2023 on sn-devel-184
Diffstat (limited to 'source3')
| -rw-r--r-- | source3/utils/status.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/source3/utils/status.c b/source3/utils/status.c index d1c69c512a8..cca8b7d6cb2 100644 --- a/source3/utils/status.c +++ b/source3/utils/status.c @@ -1185,7 +1185,8 @@ int main(int argc, const char *argv[]) fprintf(stderr, "This is normal if an SMB client has never " "connected to your server.\n"); TALLOC_FREE(db_path); - exit(0); + ret = 0; + goto done; } else { TALLOC_FREE(db); TALLOC_FREE(db_path); |