summaryrefslogtreecommitdiff
path: root/source3
diff options
context:
space:
mode:
authorAndreas Schneider <asn@samba.org>2023-01-25 10:46:03 +0100
committerJule Anger <janger@samba.org>2023-02-10 10:52:15 +0000
commit9a3fb55870da1e25e46a1b36425027240b438b2c (patch)
treed5fb4858eca725b12f2856bf9b1fcbaffc2207e6 /source3
parenta19e32ef2cbf93657b4a84d0f238d68647bfe3ac (diff)
downloadsamba-9a3fb55870da1e25e46a1b36425027240b438b2c.tar.gz
selftest: Only run samba.tests.smb3unix in developer mode
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15301 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> (cherry picked from commit 56c6f0b6d64d29a34659c9af2e4f6ee397b3e0ca)
Diffstat (limited to 'source3')
-rw-r--r--source3/param/loadparm.c4
-rwxr-xr-xsource3/selftest/tests.py5
-rw-r--r--source3/wscript1
3 files changed, 9 insertions, 1 deletions
diff --git a/source3/param/loadparm.c b/source3/param/loadparm.c
index 0eb63fe3f36..05a5ae20abe 100644
--- a/source3/param/loadparm.c
+++ b/source3/param/loadparm.c
@@ -4849,6 +4849,10 @@ uint32_t lp_get_async_dns_timeout(void)
bool lp_smb3_unix_extensions(void)
{
+ /*
+ * FIXME: If this gets always enabled, check source3/selftest/tests.py
+ * and source3/wscript for HAVE_SMB3_UNIX_EXTENSIONS.
+ */
#if defined(DEVELOPER)
return lp__smb3_unix_extensions();
#else
diff --git a/source3/selftest/tests.py b/source3/selftest/tests.py
index 93c45c9b2eb..93fb4a97f89 100755
--- a/source3/selftest/tests.py
+++ b/source3/selftest/tests.py
@@ -92,6 +92,8 @@ have_inotify = ("HAVE_INOTIFY" in config_hash)
have_ldwrap = ("HAVE_LDWRAP" in config_hash)
with_pthreadpool = ("WITH_PTHREADPOOL" in config_hash)
+have_smb3_unix_extensions = ("HAVE_SMB3_UNIX_EXTENSIONS" in config_hash)
+
def is_module_enabled(module):
if module in config_hash["STRING_SHARED_MODULES"]:
return True
@@ -1708,7 +1710,8 @@ for t in CLUSTERED_LOCAL_TESTS:
smbtorture3,
"-N 1000 -o 2000"])
-planpythontestsuite("fileserver", "samba.tests.smb3unix")
+if have_smb3_unix_extensions:
+ planpythontestsuite("fileserver", "samba.tests.smb3unix")
planpythontestsuite("fileserver", "samba.tests.reparsepoints")
planpythontestsuite("fileserver_smb1", "samba.tests.smb2symlink")
planpythontestsuite("fileserver_smb1", "samba.tests.smb1posix")
diff --git a/source3/wscript b/source3/wscript
index e77cd127e60..0dbf02ed530 100644
--- a/source3/wscript
+++ b/source3/wscript
@@ -111,6 +111,7 @@ def configure(conf):
if Options.options.developer:
conf.ADD_CFLAGS('-DDEVELOPER -DDEBUG_PASSWORD')
conf.env.developer = True
+ conf.DEFINE('HAVE_SMB3_UNIX_EXTENSIONS', '1')
if sys.platform != 'openbsd5':
conf.ADD_LDFLAGS("-Wl,--export-dynamic", testflags=True)