summaryrefslogtreecommitdiff
path: root/source3
diff options
context:
space:
mode:
authorTim Beale <timbeale@catalyst.net.nz>2018-12-12 12:23:42 +1300
committerTim Beale <timbeale@samba.org>2019-01-07 01:23:08 +0100
commite4d1d53597ac093d56ad9d528e2e580e626ab359 (patch)
tree985cb1771466e51fa1b6665b69996b998053fe2f /source3
parent6bcd64a4f14332de3259204b78c5b68988e98b6f (diff)
downloadsamba-e4d1d53597ac093d56ad9d528e2e580e626ab359.tar.gz
s3:pylibsmb: Free async .list() memory
finfos was being allocated but never freed. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676 Signed-off-by: Tim Beale <timbeale@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Diffstat (limited to 'source3')
-rw-r--r--source3/libsmb/pylibsmb.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/source3/libsmb/pylibsmb.c b/source3/libsmb/pylibsmb.c
index 64da3891783..156352d7b3d 100644
--- a/source3/libsmb/pylibsmb.c
+++ b/source3/libsmb/pylibsmb.c
@@ -987,9 +987,12 @@ static NTSTATUS do_listing(struct py_cli_state *self,
status = callback_fn(base_dir, &finfos[i], user_mask,
priv);
if (!NT_STATUS_IS_OK(status)) {
+ TALLOC_FREE(finfos);
return status;
}
}
+
+ TALLOC_FREE(finfos);
return status;
}