summaryrefslogtreecommitdiff
path: root/source3
diff options
context:
space:
mode:
authorSimo Sorce <idra@samba.org>2009-08-29 19:31:02 -0400
committerKarolin Seeger <kseeger@samba.org>2009-09-03 08:22:54 +0200
commit9a899b5542dc38b6fc501f6264abcadd2ecbea8a (patch)
tree6b1b223cc9f0b2c3acfbc4c2f0e4b852fe65f376 /source3
parentec864a5b008ba68ec3bffe489fd9776fc133c225 (diff)
downloadsamba-9a899b5542dc38b6fc501f6264abcadd2ecbea8a.tar.gz
s3-smbpasswd: Fix Bug #6584: allow DOM\user when changing passwords remotely.
Signed-off-by: Günther Deschner <gd@samba.org> (cherry picked from commit 8cb103372be4eb3232e5e13b67f63562e5506c7e)
Diffstat (limited to 'source3')
-rw-r--r--source3/libsmb/passchange.c19
1 files changed, 16 insertions, 3 deletions
diff --git a/source3/libsmb/passchange.c b/source3/libsmb/passchange.c
index 7f0389f132d..f3cb9d69d6e 100644
--- a/source3/libsmb/passchange.c
+++ b/source3/libsmb/passchange.c
@@ -31,10 +31,24 @@ NTSTATUS remote_password_change(const char *remote_machine, const char *user_nam
struct cli_state *cli;
struct rpc_pipe_client *pipe_hnd;
struct sockaddr_storage ss;
+ char *user, *domain, *p;
NTSTATUS result;
bool pass_must_change = False;
+ user = talloc_strdup(talloc_tos(), user_name);
+ SMB_ASSERT(user != NULL);
+ domain = talloc_strdup(talloc_tos(), "");
+ SMB_ASSERT(domain != NULL);
+
+ /* allow usernames of the form domain\\user or domain/user */
+ if ((p = strchr_m(user,'\\')) || (p = strchr_m(user,'/')) ||
+ (p = strchr_m(user,*lp_winbind_separator()))) {
+ *p = 0;
+ domain = user;
+ user = p+1;
+ }
+
*err_str = NULL;
if(!resolve_name( remote_machine, &ss, 0x20)) {
@@ -139,7 +153,7 @@ NTSTATUS remote_password_change(const char *remote_machine, const char *user_nam
return result;
}
} else {
- result = cli_init_creds(cli, user_name, "", old_passwd);
+ result = cli_init_creds(cli, user, domain, old_passwd);
if (!NT_STATUS_IS_OK(result)) {
cli_shutdown(cli);
return result;
@@ -163,8 +177,7 @@ NTSTATUS remote_password_change(const char *remote_machine, const char *user_nam
result = cli_rpc_pipe_open_ntlmssp(cli,
&ndr_table_samr.syntax_id,
PIPE_AUTH_LEVEL_PRIVACY,
- "", /* what domain... ? */
- user_name,
+ domain, user,
old_passwd,
&pipe_hnd);
} else {