summaryrefslogtreecommitdiff
path: root/source3/winbindd
diff options
context:
space:
mode:
authorAndreas Schneider <asn@samba.org>2021-12-14 15:46:05 +0100
committerJeremy Allison <jra@samba.org>2021-12-15 19:32:30 +0000
commit092e11295a9cfaed1cc0b70a4d1e25a6a106826c (patch)
tree76778a7a8f2253ef39e6f15dd6f31ecc6dbf071a /source3/winbindd
parent116123e9214cfc9a2c2c0f5ffe223f65ae03da05 (diff)
downloadsamba-092e11295a9cfaed1cc0b70a4d1e25a6a106826c.tar.gz
s3:winbindd: Remove dead code from sam_rids_to_names()
domain_name is never NULL in this case. Found by covscan. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
Diffstat (limited to 'source3/winbindd')
-rw-r--r--source3/winbindd/winbindd_samr.c9
1 files changed, 1 insertions, 8 deletions
diff --git a/source3/winbindd/winbindd_samr.c b/source3/winbindd/winbindd_samr.c
index 6740d11dfb0..d4ecb55fce3 100644
--- a/source3/winbindd/winbindd_samr.c
+++ b/source3/winbindd/winbindd_samr.c
@@ -968,7 +968,6 @@ static NTSTATUS sam_rids_to_names(struct winbindd_domain *domain,
for (i=0; i<num_rids; i++) {
struct dom_sid sid;
- char *dom_name = NULL;
char *name = NULL;
sid_compose(&sid, domain_sid, rids[i]);
@@ -980,16 +979,10 @@ static NTSTATUS sam_rids_to_names(struct winbindd_domain *domain,
domain,
tmp_ctx,
&sid,
- &dom_name,
+ NULL,
&name,
&types[i]);
if (NT_STATUS_IS_OK(status)) {
- if (domain_name == NULL) {
- domain_name = dom_name;
- } else {
- /* always the same */
- TALLOC_FREE(dom_name);
- }
names[i] = talloc_move(names, &name);
num_mapped += 1;
}