diff options
| author | Volker Lendecke <vl@samba.org> | 2019-02-26 12:46:39 +0100 |
|---|---|---|
| committer | Volker Lendecke <vl@samba.org> | 2019-02-28 12:57:23 +0000 |
| commit | 4faf3e9f6da7515fc263d79f77226d105c2f8524 (patch) | |
| tree | 16016f219ab9b40f8578712a69a8a5ef8744f229 /source3/winbindd | |
| parent | d9303e8eb90d48f09f2e2e8bdf01f4a7c3c21d11 (diff) | |
| download | samba-4faf3e9f6da7515fc263d79f77226d105c2f8524.tar.gz | |
idmap_cache: Only touch "sid" on success in find_xid_to_sid
Why? This makes the negative mapping condition (is_null_sid) more
explicit in the code.
The callers in lookup_sid initialized "psid" anyway before, and the ones
in wb_xids2sids now do as well. This is more in line with other APIs we
have: Only touch output parameters if you have something to say.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Christof Schmitt <cs@samba.org>
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13813
Diffstat (limited to 'source3/winbindd')
| -rw-r--r-- | source3/winbindd/wb_xids2sids.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/source3/winbindd/wb_xids2sids.c b/source3/winbindd/wb_xids2sids.c index 95dda89e40f..9e622529c17 100644 --- a/source3/winbindd/wb_xids2sids.c +++ b/source3/winbindd/wb_xids2sids.c @@ -465,7 +465,7 @@ struct tevent_req *wb_xids2sids_send(TALLOC_CTX *mem_ctx, uint32_t i; for (i=0; i<num_xids; i++) { - struct dom_sid sid; + struct dom_sid sid = {0}; bool ok, expired; switch (xids[i].type) { |