diff options
| author | Jeremy Allison <jra@samba.org> | 2009-11-12 13:56:33 -0800 |
|---|---|---|
| committer | Karolin Seeger <kseeger@samba.org> | 2009-11-26 11:40:41 +0100 |
| commit | c3ea624861a5e7863ad6c2a901ea7111b5429818 (patch) | |
| tree | 69b970c7cfa361d92cd3e273f09bca5bb469dfab /source3/utils | |
| parent | c0c4c9122d188060209cc1528a969139f02db851 (diff) | |
| download | samba-c3ea624861a5e7863ad6c2a901ea7111b5429818.tar.gz | |
Ensure all callers to the rpc_client/cli_pipe functions correctly
initialize return variables.
Jeremy.
(cherry picked from commit 5363d6e62c2d4d3275e78d04c48835524c54f620)
(cherry picked from commit 3e0add7c118cff14c3ed8f619920f4938e4795c3)
Diffstat (limited to 'source3/utils')
| -rw-r--r-- | source3/utils/net_ads.c | 4 | ||||
| -rw-r--r-- | source3/utils/net_rpc_shell.c | 2 | ||||
| -rw-r--r-- | source3/utils/net_util.c | 2 | ||||
| -rw-r--r-- | source3/utils/smbcacls.c | 2 | ||||
| -rw-r--r-- | source3/utils/smbtree.c | 2 |
5 files changed, 6 insertions, 6 deletions
diff --git a/source3/utils/net_ads.c b/source3/utils/net_ads.c index 10873cacbd8..031a338835d 100644 --- a/source3/utils/net_ads.c +++ b/source3/utils/net_ads.c @@ -1626,8 +1626,8 @@ static int net_ads_printer_publish(struct net_context *c, int argc, const char * ADS_STRUCT *ads; ADS_STATUS rc; const char *servername, *printername; - struct cli_state *cli; - struct rpc_pipe_client *pipe_hnd; + struct cli_state *cli = NULL; + struct rpc_pipe_client *pipe_hnd = NULL; struct sockaddr_storage server_ss; NTSTATUS nt_status; TALLOC_CTX *mem_ctx = talloc_init("net_ads_printer_publish"); diff --git a/source3/utils/net_rpc_shell.c b/source3/utils/net_rpc_shell.c index 5e0f1503712..39ef1cedcd0 100644 --- a/source3/utils/net_rpc_shell.c +++ b/source3/utils/net_rpc_shell.c @@ -69,7 +69,7 @@ static NTSTATUS net_sh_run(struct net_context *c, int argc, const char **argv) { TALLOC_CTX *mem_ctx; - struct rpc_pipe_client *pipe_hnd; + struct rpc_pipe_client *pipe_hnd = NULL; NTSTATUS status; mem_ctx = talloc_new(ctx); diff --git a/source3/utils/net_util.c b/source3/utils/net_util.c index d0d1fc04214..eaa2125e34f 100644 --- a/source3/utils/net_util.c +++ b/source3/utils/net_util.c @@ -28,7 +28,7 @@ NTSTATUS net_rpc_lookup_name(struct net_context *c, const char **ret_name, DOM_SID *ret_sid, enum lsa_SidType *ret_type) { - struct rpc_pipe_client *lsa_pipe; + struct rpc_pipe_client *lsa_pipe = NULL; struct policy_handle pol; NTSTATUS result = NT_STATUS_OK; const char **dom_names; diff --git a/source3/utils/smbcacls.c b/source3/utils/smbcacls.c index dfc2a92031d..eefe4fe77ce 100644 --- a/source3/utils/smbcacls.c +++ b/source3/utils/smbcacls.c @@ -70,7 +70,7 @@ static NTSTATUS cli_lsa_lookup_sid(struct cli_state *cli, char **domain, char **name) { uint16 orig_cnum = cli->cnum; - struct rpc_pipe_client *p; + struct rpc_pipe_client *p = NULL; struct policy_handle handle; NTSTATUS status; TALLOC_CTX *frame = talloc_stackframe(); diff --git a/source3/utils/smbtree.c b/source3/utils/smbtree.c index 02001f0abbd..717ce650068 100644 --- a/source3/utils/smbtree.c +++ b/source3/utils/smbtree.c @@ -148,7 +148,7 @@ static bool get_rpc_shares(struct cli_state *cli, void *state) { NTSTATUS status; - struct rpc_pipe_client *pipe_hnd; + struct rpc_pipe_client *pipe_hnd = NULL; TALLOC_CTX *mem_ctx; WERROR werr; struct srvsvc_NetShareInfoCtr info_ctr; |