summaryrefslogtreecommitdiff
path: root/source3/rpc_server/mdssvc
diff options
context:
space:
mode:
authorVolker Lendecke <vl@samba.org>2015-07-09 19:22:59 +0200
committerRalph Böhme <slow@samba.org>2015-07-09 21:59:20 +0200
commita7c215548ae55f8b37b6181bb1271a837a4078ce (patch)
tree91416fb14b51c0c6697654f3b4179d045f6f080f /source3/rpc_server/mdssvc
parent94288f153d4ae5b0f8f8a2d0d2d2870ffeccccd9 (diff)
downloadsamba-a7c215548ae55f8b37b6181bb1271a837a4078ce.tar.gz
rpc_server: Fix CID 1311339 Error handling issues (CHECKED_RETURN)
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
Diffstat (limited to 'source3/rpc_server/mdssvc')
-rw-r--r--source3/rpc_server/mdssvc/mdssvc.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/source3/rpc_server/mdssvc/mdssvc.c b/source3/rpc_server/mdssvc/mdssvc.c
index 1143b4516a8..8bf3989e353 100644
--- a/source3/rpc_server/mdssvc/mdssvc.c
+++ b/source3/rpc_server/mdssvc/mdssvc.c
@@ -1605,7 +1605,10 @@ static bool slrpc_fetch_attributes(struct mds_ctx *mds_ctx,
goto error;
}
/* For some reason the list of results always starts with a nil entry */
- dalloc_add_copy(fm_array, &nil, sl_nil_t);
+ result = dalloc_add_copy(fm_array, &nil, sl_nil_t);
+ if (result == -1) {
+ goto error;
+ }
reqinfo = dalloc_get(query, "DALLOC_CTX", 0, "sl_array_t", 1);
if (reqinfo == NULL) {