Fix coverity #740. Resource leak in error paths. We should

always return queue here as the caller will free.
Jeremy.

1 files changed, 2 insertions, 3 deletions

diff --git a/source3/printing/print_cups.c b/source3/printing/print_cups.c
index 18f42138c91..7d8248e4285 100644
--- a/source3/printing/print_cups.c
+++ b/source3/printing/print_cups.c
@@ -1342,14 +1342,12 @@ static int cups_queue_get(const char *sharename,
 	if ((response = cupsDoRequest(http, request, "/")) == NULL) {
 		DEBUG(0,("Unable to get printer status for %s - %s\n", printername,
 			 ippErrorString(cupsLastError())));
-		*q = queue;
 		goto out;
 	}
 
 	if (response->request.status.status_code >= IPP_OK_CONFLICT) {
 		DEBUG(0,("Unable to get printer status for %s - %s\n", printername,
 			 ippErrorString(response->request.status.status_code)));
-		*q = queue;
 		goto out;
 	}
 
@@ -1377,13 +1375,14 @@ static int cups_queue_get(const char *sharename,
 	        fstrcpy(status->message, msg);
 	}
 
+ out:
+
        /*
         * Return the job queue...
 	*/
 
 	*q = queue;
 
- out:
 	if (response)
 		ippDelete(response);