diff options
| author | Jeremy Allison <jra@samba.org> | 2008-11-06 20:48:13 -0800 |
|---|---|---|
| committer | Jeremy Allison <jra@samba.org> | 2008-11-06 20:48:13 -0800 |
| commit | 8962be69c700224983af4effd2cd086f7f5800b0 (patch) | |
| tree | ad2149c31ca5102a213a13a75cd511b11c64d812 /source3/passdb/passdb.c | |
| parent | 7ae625345536572aa946f0715542a5cf2dbc2169 (diff) | |
| download | samba-8962be69c700224983af4effd2cd086f7f5800b0.tar.gz | |
Make us clean under valgrind --leak-check=full by using talloc_autofree_context() instead of NULL.
Remove the code in memcache that does a TALLOC_FREE on stored pointers. That's a disaster waiting
to happen. If you're storing talloc'ed pointers, you can't know their lifecycle and they should
be deleted when their parent context is deleted, so freeing them at some arbitrary point later
will be a double-free.
Jeremy.
Diffstat (limited to 'source3/passdb/passdb.c')
| -rw-r--r-- | source3/passdb/passdb.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/source3/passdb/passdb.c b/source3/passdb/passdb.c index 60699615f0e..8367d6a9ad8 100644 --- a/source3/passdb/passdb.c +++ b/source3/passdb/passdb.c @@ -665,7 +665,7 @@ NTSTATUS local_password_change(const char *user_name, DEBUGLEVEL = 1; } - if ( !(pwd = getpwnam_alloc( NULL, user_name)) ) { + if ( !(pwd = getpwnam_alloc(talloc_autofree_context(), user_name)) ) { return NT_STATUS_NO_SUCH_USER; } |