diff options
| author | Pavel Filipenský <pfilipen@redhat.com> | 2022-01-07 13:16:26 +0100 |
|---|---|---|
| committer | Jeremy Allison <jra@samba.org> | 2022-01-10 23:31:33 +0000 |
| commit | 4d7ed39fd8fa18f90756f215c8b0fc5d293e955e (patch) | |
| tree | 1065fdbb73a3a35bd83ca833c1b97fb8f5d10146 /source3/modules/vfs_crossrename.c | |
| parent | 41ebb7f68c5b21492f503afc4cb341a97654a43d (diff) | |
| download | samba-4d7ed39fd8fa18f90756f215c8b0fc5d293e955e.tar.gz | |
s3:modules: Fix the horrible vfs_crossrename module
It really has to be removed! ;-)
Found by covscan. The code always leaves here as the dst variable
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14940
Pair-programmed-with: Andreas Schneider <asn@samba.org>
Signed-off-by: Pavel Filipenský <pfilipen@redhat.com>
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Diffstat (limited to 'source3/modules/vfs_crossrename.c')
| -rw-r--r-- | source3/modules/vfs_crossrename.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/source3/modules/vfs_crossrename.c b/source3/modules/vfs_crossrename.c index 52b8af9d3f6..930eec02739 100644 --- a/source3/modules/vfs_crossrename.c +++ b/source3/modules/vfs_crossrename.c @@ -82,7 +82,7 @@ static NTSTATUS copy_reg(vfs_handle_struct *handle, full_fname_src = full_path_from_dirfsp_atname(talloc_tos(), srcfsp, source); - if (full_fname_dst == NULL) { + if (full_fname_src == NULL) { status = NT_STATUS_NO_MEMORY; goto out; } |