diff options
| author | Jeremy Allison <jra@samba.org> | 2017-11-29 13:10:25 -0800 |
|---|---|---|
| committer | Volker Lendecke <vl@samba.org> | 2017-11-30 15:30:23 +0100 |
| commit | 8448dcaa8da78bcb84fca6a000c75e256bce1e77 (patch) | |
| tree | aef27afa59c1160894787eca5ec770cd32d7546c /source3/libsmb | |
| parent | d7a5cd589b7b16d625dbc64dac21a1384519e32b (diff) | |
| download | samba-8448dcaa8da78bcb84fca6a000c75e256bce1e77.tar.gz | |
s3: client: Rename <oldname> to <link_target> in cmd_symlink() and cli_posix_symlink().
Stops us from mixing up the old and new names. Only behavior change
is correcting the names printed in the error messages.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13172
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Diffstat (limited to 'source3/libsmb')
| -rw-r--r-- | source3/libsmb/clifile.c | 15 |
1 files changed, 8 insertions, 7 deletions
diff --git a/source3/libsmb/clifile.c b/source3/libsmb/clifile.c index a6a0bafa2cd..e942b27e175 100644 --- a/source3/libsmb/clifile.c +++ b/source3/libsmb/clifile.c @@ -151,7 +151,7 @@ NTSTATUS cli_setpathinfo(struct cli_state *cli, /**************************************************************************** Hard/Symlink a file (UNIX extensions). - Creates new name (sym)linked to oldname. + Creates new name (sym)linked to link_target. ****************************************************************************/ struct cli_posix_link_internal_state { @@ -164,7 +164,7 @@ static struct tevent_req *cli_posix_link_internal_send(TALLOC_CTX *mem_ctx, struct tevent_context *ev, struct cli_state *cli, uint16_t level, - const char *oldname, + const char *link_target, const char *newname) { struct tevent_req *req = NULL, *subreq = NULL; @@ -182,7 +182,8 @@ static struct tevent_req *cli_posix_link_internal_send(TALLOC_CTX *mem_ctx, return tevent_req_post(req, ev); } state->data = trans2_bytes_push_str( - state->data, smbXcli_conn_use_unicode(cli->conn), oldname, strlen(oldname)+1, NULL); + state->data, smbXcli_conn_use_unicode(cli->conn), + link_target, strlen(link_target)+1, NULL); subreq = cli_setpathinfo_send( state, ev, cli, level, newname, @@ -207,11 +208,11 @@ static void cli_posix_link_internal_done(struct tevent_req *subreq) struct tevent_req *cli_posix_symlink_send(TALLOC_CTX *mem_ctx, struct tevent_context *ev, struct cli_state *cli, - const char *oldname, + const char *link_target, const char *newname) { return cli_posix_link_internal_send( - mem_ctx, ev, cli, SMB_SET_FILE_UNIX_LINK, oldname, newname); + mem_ctx, ev, cli, SMB_SET_FILE_UNIX_LINK, link_target, newname); } NTSTATUS cli_posix_symlink_recv(struct tevent_req *req) @@ -220,7 +221,7 @@ NTSTATUS cli_posix_symlink_recv(struct tevent_req *req) } NTSTATUS cli_posix_symlink(struct cli_state *cli, - const char *oldname, + const char *link_target, const char *newname) { TALLOC_CTX *frame = talloc_stackframe(); @@ -245,7 +246,7 @@ NTSTATUS cli_posix_symlink(struct cli_state *cli, req = cli_posix_symlink_send(frame, ev, cli, - oldname, + link_target, newname); if (req == NULL) { status = NT_STATUS_NO_MEMORY; |