diff options
| author | Jeremy Allison <jra@samba.org> | 2016-01-06 15:03:47 -0800 |
|---|---|---|
| committer | Volker Lendecke <vl@samba.org> | 2016-01-07 16:00:02 +0100 |
| commit | 8108f0d320013c560339723d8d70ab601350d0c4 (patch) | |
| tree | 9acfe6fda915d1eef0ba90366690aaaa00bb539d /source3/libsmb/clispnego.c | |
| parent | 8ca6fe6d75f296f70a51513063466e48691028d9 (diff) | |
| download | samba-8108f0d320013c560339723d8d70ab601350d0c4.tar.gz | |
s3: smbclient: asn1_extract_blob() stops further asn1 processing by setting has_error.
Don't call asn1_has_error() after asn1_extract_blob() has been successful
otherwise we get an "Failed to build negTokenInit at offset" message
on success.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Thu Jan 7 16:00:02 CET 2016 on sn-devel-144
Diffstat (limited to 'source3/libsmb/clispnego.c')
| -rw-r--r-- | source3/libsmb/clispnego.c | 15 |
1 files changed, 10 insertions, 5 deletions
diff --git a/source3/libsmb/clispnego.c b/source3/libsmb/clispnego.c index 5cf476bda8a..3300c85340a 100644 --- a/source3/libsmb/clispnego.c +++ b/source3/libsmb/clispnego.c @@ -83,14 +83,19 @@ DATA_BLOB spnego_gen_negTokenInit(TALLOC_CTX *ctx, goto err; } + asn1_free(data); + data = NULL; + err: - if (asn1_has_error(data)) { - DEBUG(1, ("Failed to build negTokenInit at offset %d\n", - (int)asn1_current_ofs(data))); - } + if (data != NULL) { + if (asn1_has_error(data)) { + DEBUG(1, ("Failed to build negTokenInit at offset %d\n", + (int)asn1_current_ofs(data))); + } - asn1_free(data); + asn1_free(data); + } return ret; } |