diff options
| author | Lutz Justen <ljusten@google.com> | 2018-04-04 09:50:12 -0700 |
|---|---|---|
| committer | Karolin Seeger <kseeger@samba.org> | 2018-04-10 09:38:08 +0200 |
| commit | d217375a87d49d65aeff9957d50046722b40e734 (patch) | |
| tree | aec89e781b4609d24b945d74d9b92ca663018954 /source3/lib | |
| parent | c62c1c93f5712e7c3590eb9b9df9573300bd229a (diff) | |
| download | samba-d217375a87d49d65aeff9957d50046722b40e734.tar.gz | |
s3: lib: messages: Don't use the result of sec_init() before calling sec_init().
Commit ad8c7171ba86e8a47d78b0c7329bb814e5a8871e accidently
moved sec_init() to the point after sec_initial_uid() is
called in the call to directory_create_or_exist_strict().
I missed this in the review (sorry). This works as root
as initial_uid/initial_gid are static (and so initialized
as zero) but doesn't work on ChromeOS as this code isn't
running as root.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13368
Signed-off-by: Lutz Justen <ljusten@google.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Apr 4 23:52:02 CEST 2018 on sn-devel-144
(cherry picked from commit e895b6cf4a7eb3d50d618a022be74db85975bf69)
Diffstat (limited to 'source3/lib')
| -rw-r--r-- | source3/lib/messages.c | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/source3/lib/messages.c b/source3/lib/messages.c index b94a6965eb8..fca39948329 100644 --- a/source3/lib/messages.c +++ b/source3/lib/messages.c @@ -248,6 +248,13 @@ static NTSTATUS messaging_init_internal(TALLOC_CTX *mem_ctx, const char *priv_path; bool ok; + /* + * sec_init() *must* be called before any other + * functions that use sec_XXX(). e.g. sec_initial_uid(). + */ + + sec_init(); + lck_path = lock_path("msg.lock"); if (lck_path == NULL) { return NT_STATUS_NO_MEMORY; @@ -292,8 +299,6 @@ static NTSTATUS messaging_init_internal(TALLOC_CTX *mem_ctx, ctx->event_ctx = ev; - sec_init(); - ctx->msg_dgm_ref = messaging_dgm_ref(ctx, ctx->event_ctx, &ctx->id.unique_id, |