diff options
| author | Andreas Schneider <asn@samba.org> | 2014-02-17 10:50:17 +0100 |
|---|---|---|
| committer | Andreas Schneider <asn@samba.org> | 2014-02-19 18:22:30 +0100 |
| commit | 034da62e6bfa006974aac345d5140344c136a2d5 (patch) | |
| tree | ef7f8c2ca00e66c923f47eae8a75ac22914f7395 /source3/client | |
| parent | 7bb9836c94e5659a2b9d6cca3becdd1dfc205932 (diff) | |
| download | samba-034da62e6bfa006974aac345d5140344c136a2d5.tar.gz | |
s3-clitar: Improve readabilty of cmd_setmode().
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Diffstat (limited to 'source3/client')
| -rw-r--r-- | source3/client/clitar.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/source3/client/clitar.c b/source3/client/clitar.c index 3d7f8ef55e2..ad66b9916e0 100644 --- a/source3/client/clitar.c +++ b/source3/client/clitar.c @@ -394,9 +394,11 @@ int cmd_setmode(void) int mode = ATTR_SET; TALLOC_CTX *ctx = PANIC_IF_NULL(talloc_new(NULL)); int err = 0; + bool ok; - if (!next_token_talloc(ctx, &cmd_ptr, &buf, NULL)) { + ok = next_token_talloc(ctx, &cmd_ptr, &buf, NULL); + if (!ok) { DBG(0, ("setmode <filename> <[+|-]rsha>\n")); err = 1; goto out; @@ -406,7 +408,7 @@ int cmd_setmode(void) "%s%s", client_get_cur_dir(), buf)); - if (!fname) { + if (fname == NULL) { err = 1; goto out; } |