diff options
| author | Jim McDonough <jmcd@samba.org> | 2006-03-13 01:32:30 +0000 |
|---|---|---|
| committer | Gerald (Jerry) Carter <jerry@samba.org> | 2007-10-10 11:15:22 -0500 |
| commit | 1804a8a01ebf3353574a2c5b26a1746b34715737 (patch) | |
| tree | 305ecf2595189f11d580b8f1b1970290eff57775 /source/utils/smbcacls.c | |
| parent | aeae20a8d9f3658acb8edd373eb601bdf7eab98b (diff) | |
| download | samba-1804a8a01ebf3353574a2c5b26a1746b34715737.tar.gz | |
r14278: Remainder of fix for Coverity #79,80,81: only allow GROUP or OWNER to be
specified once in an ACL, so it can be allocated a second time,
overwriting the first
Diffstat (limited to 'source/utils/smbcacls.c')
| -rw-r--r-- | source/utils/smbcacls.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/source/utils/smbcacls.c b/source/utils/smbcacls.c index 8c08e7f2f14..1c34cd32a66 100644 --- a/source/utils/smbcacls.c +++ b/source/utils/smbcacls.c @@ -392,6 +392,10 @@ static SEC_DESC *sec_desc_parse(char *str) } if (strncmp(tok,"OWNER:", 6) == 0) { + if (owner_sid) { + printf("Only specify owner once\n"); + goto done; + } owner_sid = SMB_CALLOC_ARRAY(DOM_SID, 1); if (!owner_sid || !StringToSid(owner_sid, tok+6)) { @@ -402,6 +406,10 @@ static SEC_DESC *sec_desc_parse(char *str) } if (strncmp(tok,"GROUP:", 6) == 0) { + if (grp_sid) { + printf("Only specify group once\n"); + goto done; + } grp_sid = SMB_CALLOC_ARRAY(DOM_SID, 1); if (!grp_sid || !StringToSid(grp_sid, tok+6)) { |