summaryrefslogtreecommitdiff
path: root/source/lsarpcd
diff options
context:
space:
mode:
authorLuke Leighton <lkcl@samba.org>2000-02-12 18:31:31 +0000
committerLuke Leighton <lkcl@samba.org>2000-02-12 18:31:31 +0000
commit5531dc01f121d350df217fb433697039a0e74fba (patch)
tree7e42db260a641e5e86f48d974e7308dadc3b7a5b /source/lsarpcd
parentf7e4d740b8db76d38750fad6a62d7a7ee7af7f67 (diff)
downloadsamba-5531dc01f121d350df217fb433697039a0e74fba.tar.gz
From Elrond@Wunder-Nett.org Sun Feb 13 05:30:09 2000
Date: Sat, 12 Feb 2000 19:00:20 +0100 From: Elrond <Elrond@Wunder-Nett.org> To: Luke Kenneth Casson Leighton <lkcl@samba.org> Subject: some cleanups Some clean-ups, I made this morning: - Re-added spool- and at-commands to rpcclient - One of these "automated" xxx_io_xxx-return-checkers went wrong in srv_lsa.c - instead of exporting the command-tables in rpcclient/*_cmds.c, those export now a add_xxx_commands(), that adds these commands and the table can now be static const (and so ends up in the shared readonly-data segment)
Diffstat (limited to 'source/lsarpcd')
-rw-r--r--source/lsarpcd/secret_db.c2
-rw-r--r--source/lsarpcd/srv_lsa.c6
2 files changed, 2 insertions, 6 deletions
diff --git a/source/lsarpcd/secret_db.c b/source/lsarpcd/secret_db.c
index 08288f0ec7c..3a5bc1b0903 100644
--- a/source/lsarpcd/secret_db.c
+++ b/source/lsarpcd/secret_db.c
@@ -60,7 +60,7 @@ BOOL tdb_lookup_secret( TDB_CONTEXT *tdb, const UNISTR2 *uk, LSA_SECRET **usr)
if (usr != NULL)
{
- (*usr) = (LSA_SECRET *)malloc(sizeof(**usr));
+ (*usr) = g_new(LSA_SECRET, 1);
if ((*usr) == NULL)
{
return False;
diff --git a/source/lsarpcd/srv_lsa.c b/source/lsarpcd/srv_lsa.c
index e652f09ee4c..1ca01658c27 100644
--- a/source/lsarpcd/srv_lsa.c
+++ b/source/lsarpcd/srv_lsa.c
@@ -312,11 +312,7 @@ static BOOL api_lsa_open_policy( rpcsrv_struct *p, prs_struct *data,
r_o.status = _lsa_open_policy(NULL, &r_o.pol,
&q_o.attr, q_o.des_access);
- lsa_io_r_open_pol("", &r_o, rdata, 0);
- {
- return False;
- }
- return True;
+ return lsa_io_r_open_pol("", &r_o, rdata, 0);
}
/***************************************************************************