tridge the destroyer returns!

prompted by the interpret_security() dead code that Jean-Francois
pointed out I added a make target "finddead" that finds potentially
dead (ie. unused) code. It spat out 304 function names ...

I went through these are deleted many of them, making others static
(finddead also reports functions that are used only in the local
file).

in doing this I have almost certainly deleted some useful code. I may
have even prevented compilation with some compile options. I
apologise. I decided it was better to get rid of this code now and add
back the one or two functions that are needed than to keep all this
baggage.

So, if I have done a bit too much "destroying" then let me know. Keep
the swearing to a minimum :)

One bit I didn't do is the ubibt code. Chris, can you look at that?
Heaps of unused functions there. Can they be made static?

3 files changed, 6 insertions, 26 deletions

diff --git a/source/libsmb/clientgen.c b/source/libsmb/clientgen.c
index 52919d9eb41..c85de929893 100644
--- a/source/libsmb/clientgen.c
+++ b/source/libsmb/clientgen.c
@@ -51,7 +51,7 @@ struct
 /****************************************************************************
   return a description of an SMB error
 ****************************************************************************/
-char *cli_smb_errstr(struct cli_state *cli)
+static char *cli_smb_errstr(struct cli_state *cli)
 {
 	return smb_errstr(cli->inbuf);
 }
@@ -425,6 +425,7 @@ BOOL cli_NetWkstaUserLogon(struct cli_state *cli,char *user, char *workstation)
 	return (cli->rap_error == 0);
 }
 
+#if UNUSED_CODE
 /****************************************************************************
 call a NetShareEnum - try and browse available connections on a host
 ****************************************************************************/
@@ -480,6 +481,7 @@ BOOL cli_RNetShareEnum(struct cli_state *cli, void (*fn)(char *, uint32, char *)
 
   return(count>0);
 }
+#endif
 
 /****************************************************************************
 call a NetServerEnum for the specified workgroup and servertype mask.
@@ -763,6 +765,7 @@ BOOL cli_tdis(struct cli_state *cli)
 	return CVAL(cli->inbuf,smb_rcls) == 0;
 }
 
+#if UNUSED_CODE
 /****************************************************************************
 rename a file
 ****************************************************************************/
@@ -799,6 +802,7 @@ BOOL cli_mv(struct cli_state *cli, char *fname_src, char *fname_dst)
 
         return True;
 }
+#endif
 
 /****************************************************************************
 delete a file
diff --git a/source/libsmb/nmblib.c b/source/libsmb/nmblib.c
index ab57590b6f7..d08003133f1 100644
--- a/source/libsmb/nmblib.c
+++ b/source/libsmb/nmblib.c
@@ -44,8 +44,7 @@ static struct opcode_names {
 /****************************************************************************
  * Lookup a nmb opcode name.
  ****************************************************************************/
-
-char *lookup_opcode_name( int opcode )
+static char *lookup_opcode_name( int opcode )
 {
   struct opcode_names *op_namep;
   int i;
diff --git a/source/libsmb/smbencrypt.c b/source/libsmb/smbencrypt.c
index 052dae06f10..6840f2e2c83 100644
--- a/source/libsmb/smbencrypt.c
+++ b/source/libsmb/smbencrypt.c
@@ -109,27 +109,4 @@ void SMBNTencrypt(uchar *passwd, uchar *c8, uchar *p24)
 	E_P24(p21, c8, p24);
 }
 
-/* Does both the NT and LM owfs of a user's password */
-
-void nt_lm_owf_gen(char *pwd, char *nt_p16, char *p16)
-{
-	char passwd[130];
-	StrnCpy(passwd, pwd, sizeof(passwd)-1);
-
-	/* Calculate the MD4 hash (NT compatible) of the password */
-	memset(nt_p16, '\0', 16);
-	E_md4hash((uchar *)passwd, (uchar *)nt_p16);
-
-	/* Mangle the passwords into Lanman format */
-	passwd[14] = '\0';
-	strupper(passwd);
-
-	/* Calculate the SMB (lanman) hash functions of the password */
-
-	memset(p16, '\0', 16);
-	E_P16((uchar *) passwd, (uchar *)p16);
-
-	/* clear out local copy of user's password (just being paranoid). */
-	bzero(passwd, sizeof(passwd));
-}