diff options
| author | Christof Schmitt <cs@samba.org> | 2018-11-02 12:08:23 -0700 |
|---|---|---|
| committer | Karolin Seeger <kseeger@samba.org> | 2018-11-07 08:44:31 +0100 |
| commit | d60ad0171a09b57667ac0888ce95f22dd16d7630 (patch) | |
| tree | 080c481d9228d7e60e9320fe1f2ba56ab76e7547 /selftest | |
| parent | e674f23a10662e0dc04630d1f548585258008c32 (diff) | |
| download | samba-d60ad0171a09b57667ac0888ce95f22dd16d7630.tar.gz | |
smbd: Fix DELETE_ON_CLOSE behaviour on files with READ_ONLY attribute
MS-FSA states that a CREATE with FILE_DELETE_ON_CLOSE on an existing
file with READ_ONLY attribute has to return STATUS_CANNOT_DELETE. This
was missing in smbd as the check used the DOS attributes from the CREATE
instead of the DOS attributes on the existing file.
We need to handle the new file and existing file cases separately.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13673
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 162a5257c48f20d3752f644e86c9e626b46436c0)
Diffstat (limited to 'selftest')
| -rw-r--r-- | selftest/knownfail | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/selftest/knownfail b/selftest/knownfail index 781c14551fe..84776d4f35d 100644 --- a/selftest/knownfail +++ b/selftest/knownfail @@ -348,5 +348,3 @@ # Disabling NTLM means you can't use samr to change the password ^samba.tests.ntlmdisabled.python\(ktest\).ntlmdisabled.NtlmDisabledTests.test_samr_change_password\(ktest\) ^samba.tests.ntlmdisabled.python\(ad_dc_no_ntlm\).ntlmdisabled.NtlmDisabledTests.test_ntlm_connection\(ad_dc_no_ntlm\) -^samba3.smb2.delete-on-close-perms.READONLY\(nt4_dc\) -^samba3.smb2.delete-on-close-perms.READONLY\(ad_dc\) |