diff options
| author | Stefan Metzmacher <metze@samba.org> | 2018-11-28 15:21:56 +0100 |
|---|---|---|
| committer | Karolin Seeger <kseeger@samba.org> | 2018-12-07 16:59:16 +0100 |
| commit | 23b41ebe1deca762e03d4d688f0a11e11f809afd (patch) | |
| tree | 9a2d90b3d3d849f728d3325fa01830566c574a66 /selftest | |
| parent | afc799126853e1ce9cb498c4cc0eb17b9e0dd565 (diff) | |
| download | samba-23b41ebe1deca762e03d4d688f0a11e11f809afd.tar.gz | |
CVE-2018-14629 dns: fix CNAME loop prevention using counter regression
The loop prevention should only be done for CNAME records!
Otherwise we truncate the answer records for A, AAAA or
SRV queries, which is a bad idea if you have more than 20 DCs.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13600
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Dec 4 08:52:29 CET 2018 on sn-devel-144
(cherry picked from commit 34f4491d79b47b2fe2457b8882f11644cf773bc4)
Autobuild-User(v4-7-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-7-test): Fri Dec 7 16:59:16 CET 2018 on sn-devel-144
Diffstat (limited to 'selftest')
| -rw-r--r-- | selftest/knownfail.d/dns | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/selftest/knownfail.d/dns b/selftest/knownfail.d/dns index bd12d439c11..c26a31aeb4e 100644 --- a/selftest/knownfail.d/dns +++ b/selftest/knownfail.d/dns @@ -61,9 +61,3 @@ samba.tests.dns.__main__.TestSimpleQueries.test_one_SOA_query\(rodc:local\) ^samba.tests.dns.__main__.TestComplexQueries.test_cname_limit\(rodc:local\) ^samba.tests.dns.__main__.TestComplexQueries.test_cname_any_query\(vampire_dc:local\) ^samba.tests.dns.__main__.TestComplexQueries.test_cname_any_query\(rodc:local\) - -# These all fail until the next patch -^samba.tests.dns.__main__.TestComplexQueries.test_cname_limit -^samba.tests.dns.__main__.TestComplexQueries.test_record_limit_SRV -^samba.tests.dns.__main__.TestComplexQueries.test_record_limit_AAAA -^samba.tests.dns.__main__.TestComplexQueries.test_record_limit_A |