diff options
| author | Noel Power <noel.power@suse.com> | 2019-12-19 18:39:09 +0000 |
|---|---|---|
| committer | Ralph Boehme <slow@samba.org> | 2020-04-03 15:08:33 +0000 |
| commit | e7b4b349069b34fee920f83740fa2863320829b6 (patch) | |
| tree | d45ca819b86a77df163ada6e28f4f9cdbd3868d5 /selftest | |
| parent | 84ba205d1dfeffa74e754b9f819feed926e7542b (diff) | |
| download | samba-e7b4b349069b34fee920f83740fa2863320829b6.tar.gz | |
selftest/knownfail.d: Add samba4.blackbox.smbclient
This test fails for admember & chgdcpass test envs because they
don't support SMB1
Note: There is some coverage for this test with other test envs e.g.
s4member, ad_dc_ntvfs & others
Additionally IIUC this test seems to be for testing smbclient4
(if this assumption is incorrect then we could substitute with
smbclient(s3)) However, for the moment it seems best to disable this
test as smbclient4 doesn't support SMB1 and we have sufficient coverage
with other SMB1 supporting envs
Also remove associated entries from skip_smb1_fail
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
Diffstat (limited to 'selftest')
| -rw-r--r-- | selftest/knownfail.d/smb1-tests | 4 | ||||
| -rw-r--r-- | selftest/skip_smb1_fails | 2 |
2 files changed, 4 insertions, 2 deletions
diff --git a/selftest/knownfail.d/smb1-tests b/selftest/knownfail.d/smb1-tests index 61918d12cb0..c0b196b421b 100644 --- a/selftest/knownfail.d/smb1-tests +++ b/selftest/knownfail.d/smb1-tests @@ -40,3 +40,7 @@ ^samba4.smb.signing disabled on with -k no --signing=off domain-creds.xcopy\(ad_member\) ^samba4.smb.signing disabled on with -k no --option=gensec:spengo=no --signing=off domain-creds.xcopy\(ad_member\) ^samba4.smb.signing disabled on with -k yes --signing=off domain-creds.xcopy\(ad_member\) +^samba4.blackbox.smbclient\(ad_member:local\).Test login with --machine-pass without kerberos\(ad_member:local\) +^samba4.blackbox.smbclient\(ad_member:local\).Test login with --machine-pass and kerberos\(ad_member:local\) +^samba4.blackbox.smbclient\(chgdcpass:local\).Test login with --machine-pass without kerberos\(chgdcpass:local\) +^samba4.blackbox.smbclient\(chgdcpass:local\).Test login with --machine-pass and kerberos\(chgdcpass:local\) diff --git a/selftest/skip_smb1_fails b/selftest/skip_smb1_fails index 2e7670b38c9..0aa9e3dc259 100644 --- a/selftest/skip_smb1_fails +++ b/selftest/skip_smb1_fails @@ -7,5 +7,3 @@ # b) port the failing test to SMB2 # c) fix the test ^samba3.blackbox.smbclient_basic.NT1\(nt4_dc_schannel\) -^samba4.blackbox.smbclient\(ad_member:local\)\(ad_member:local\) -^samba4.blackbox.smbclient\(chgdcpass:local\)\(chgdcpass:local\) |