diff options
| author | Tim Beale <timbeale@catalyst.net.nz> | 2018-04-18 14:21:46 +1200 |
|---|---|---|
| committer | Garming Sam <garming@samba.org> | 2018-05-23 06:55:31 +0200 |
| commit | e40af276f8d0eb8fd7e38094101b1874177ea6b0 (patch) | |
| tree | 142f2f895fea743def24f6536940423fec8bc038 /selftest | |
| parent | 05e25a728c9260fe1696500ed26a7c4f9ad85c57 (diff) | |
| download | samba-e40af276f8d0eb8fd7e38094101b1874177ea6b0.tar.gz | |
dsdb: Lookup PSO's lockout settings for password_hash modifies
When a user's password-hash is modified, we need the PSO settings for
that user, so that any lockout settings get applied correctly.
To do this, we query the msDS-ResultantPSO in the user search. Then, if
a PSO applies to the user, we add in a extra search to retrieve the
PSO's settings. Once the PSO search completes, we continue with the
modify operation.
In the event of error cases, I've tried to fallback to logging the
problem and continuing with the default domain settings. However,
unusual internal errors will still fail the operation.
We can pass the PSO result into dsdb_update_bad_pwd_count(), which means
the PSO's lockout-threshold and observation-window are now used. This is
enough to get the remaining lockout tests passing.
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Diffstat (limited to 'selftest')
| -rw-r--r-- | selftest/knownfail.d/password_lockout | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/selftest/knownfail.d/password_lockout b/selftest/knownfail.d/password_lockout deleted file mode 100644 index 58f047f8aef..00000000000 --- a/selftest/knownfail.d/password_lockout +++ /dev/null @@ -1,3 +0,0 @@ -samba4.ldap.password_lockout.python\(ad_dc_ntvfs\).__main__.PasswordTests.test_pso_userPassword_lockout_with_clear_change_krb5_ldap_userAccountControl\(ad_dc_ntvfs\) -samba4.ldap.password_lockout.python\(ad_dc_ntvfs\).__main__.PasswordTests.test_pso_userPassword_lockout_with_clear_change_ntlm_ldap_lockoutTime\(ad_dc_ntvfs\) -samba4.ldap.password_lockout.python\(ad_dc_ntvfs\).__main__.PasswordTests.test_pso_userPassword_lockout_with_clear_change_ntlm_samr\(ad_dc_ntvfs\) |