summaryrefslogtreecommitdiff
path: root/selftest
diff options
context:
space:
mode:
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>2016-12-07 14:35:58 +1300
committerDouglas Bagnall <dbagnall@samba.org>2016-12-14 05:02:24 +0100
commit6c9a185be260a914bc0bd2dcf76c9dcb9664a687 (patch)
tree38929c12f8914751b645ae5742ec43dc5ea34d33 /selftest
parentc0549aea68662cb7a1309d358fc8480f0023e360 (diff)
downloadsamba-6c9a185be260a914bc0bd2dcf76c9dcb9664a687.tar.gz
s4-torture: better, failing, tests for GUID_from_string
These tests reveal that the current implementation accepts all kinds of invalid GUIDs. In particular, we fail on these ones: "00000001-0002-0003-0405--060708090a0" "-0000001-0002-0003-0405-060708090a0b" "-0000001-0002-0003-04-5-060708090a0b" "d0000001-0002-0003-0405-060708090a-b" "00000001- -2-0003-0405-060708090a0b" "00000001-0002-0003-0405- 060708090a0" "0x000001-0002-0003-0405-060708090a0b" "00000001-0x02-0x03-0405-060708090a0b" This test is added to selftest/knownfail. The test for valid string GUIDs is extended to test upper and mixed case GUIDs. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Diffstat (limited to 'selftest')
-rw-r--r--selftest/knownfail1
1 files changed, 1 insertions, 0 deletions
diff --git a/selftest/knownfail b/selftest/knownfail
index 97ec6ef1d64..f6493818468 100644
--- a/selftest/knownfail
+++ b/selftest/knownfail
@@ -309,3 +309,4 @@
^samba.tests.dcerpc.dnsserver.samba.tests.dcerpc.dnsserver.DnsserverTests.test_add_duplicate_different_type.*
^samba.tests.dcerpc.dnsserver.samba.tests.dcerpc.dnsserver.DnsserverTests.test_rank_none.*
^samba.tests.dcerpc.dnsserver.samba.tests.dcerpc.dnsserver.DnsserverTests.test_security_descriptor.*
+^samba4.local.ndr.*.guid_from_string_invalid