diff options
| author | Tim Beale <timbeale@catalyst.net.nz> | 2018-04-19 10:46:48 +1200 |
|---|---|---|
| committer | Garming Sam <garming@samba.org> | 2018-05-23 06:55:31 +0200 |
| commit | 3b849f87f7237a3677338075309abb1355a4d9ef (patch) | |
| tree | 596d305041ed4bfbcb1ea4f8ea431ae9603f1e23 /selftest | |
| parent | 0ac464df4543154ee8a1cbf03684d8b99bcb92b3 (diff) | |
| download | samba-3b849f87f7237a3677338075309abb1355a4d9ef.tar.gz | |
dsdb: Update password_hash to use PSO settings for password changes
Honour the settings in the PSO when changing the password, i.e.
msDS-PasswordComplexityEnabled, msDS-PasswordHistoryLength, etc.
The password_hash code populates dsdb_control_password_change_status's
domain_data with the password settings to use - these are currently
based on the settings for the domain.
Now, if the password_hash code has worked out that a PSO applies to the
user, we override the domain settings with the PSO's values.
This change means the password_settings tests now pass.
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Diffstat (limited to 'selftest')
| -rw-r--r-- | selftest/knownfail.d/password_hash_gpgme | 2 | ||||
| -rw-r--r-- | selftest/knownfail.d/password_settings | 6 |
2 files changed, 0 insertions, 8 deletions
diff --git a/selftest/knownfail.d/password_hash_gpgme b/selftest/knownfail.d/password_hash_gpgme deleted file mode 100644 index a382714e5a8..00000000000 --- a/selftest/knownfail.d/password_hash_gpgme +++ /dev/null @@ -1,2 +0,0 @@ -samba.tests.password_hash_gpgme.samba.tests.password_hash_gpgme.PassWordHashGpgmeTests.test_supplementalCredentials_cleartext_pso\(ad_dc:local\) - diff --git a/selftest/knownfail.d/password_settings b/selftest/knownfail.d/password_settings index a0cf46fda71..b23f3f9ef42 100644 --- a/selftest/knownfail.d/password_settings +++ b/selftest/knownfail.d/password_settings @@ -1,8 +1,2 @@ -samba4.ldap.password_settings.python.password_settings.PasswordSettingsTestCase.test_pso_basics\(ad_dc_ntvfs\) -samba4.ldap.password_settings.python.password_settings.PasswordSettingsTestCase.test_pso_equal_precedence\(ad_dc_ntvfs\) -samba4.ldap.password_settings.python.password_settings.PasswordSettingsTestCase.test_pso_nested_groups\(ad_dc_ntvfs\) -samba4.ldap.password_settings.python.password_settings.PasswordSettingsTestCase.test_pso_special_groups\(ad_dc_ntvfs\) -samba4.ldap.password_settings.python.password_settings.PasswordSettingsTestCase.test_pso_min_age\(ad_dc_ntvfs\) samba4.ldap.password_settings.python.password_settings.PasswordSettingsTestCase.test_pso_max_age\(ad_dc_ntvfs\) -samba4.ldap.password_settings.python.password_settings.PasswordSettingsTestCase.test_pso_add_user\(ad_dc_ntvfs\) |