summaryrefslogtreecommitdiff
path: root/selftest
diff options
context:
space:
mode:
authorJoseph Sutton <josephsutton@catalyst.net.nz>2021-09-25 14:39:59 +1200
committerStefan Metzmacher <metze@samba.org>2021-10-26 14:22:09 +0000
commit9e2da222f7f9993443cabcd42cd38e61abcd7a5d (patch)
tree6b20974c3637a8c36c5ae000dd8fc5720282bd06 /selftest
parentb4601d0db20c4ccb933c0264c577fe0df07923c1 (diff)
downloadsamba-9e2da222f7f9993443cabcd42cd38e61abcd7a5d.tar.gz
pyldb: Make ldb.Message containment testing consistent with indexing
Previously, containment testing using the 'in' operator was handled by performing an equality comparison between the chosen object and each of the message's keys in turn. This behaviour was prone to errors due to not considering differences in case between otherwise equal elements, as the indexing operations do. Containment testing should now be more consistent with the indexing operations and with the get() method of ldb.Message. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14845 Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> (cherry picked from commit 860d8902a9c502d4be83396598cf4a53c80fea69)
Diffstat (limited to 'selftest')
-rw-r--r--selftest/knownfail.d/pyldb4
1 files changed, 0 insertions, 4 deletions
diff --git a/selftest/knownfail.d/pyldb b/selftest/knownfail.d/pyldb
deleted file mode 100644
index 34bdac4f682..00000000000
--- a/selftest/knownfail.d/pyldb
+++ /dev/null
@@ -1,4 +0,0 @@
-^ldb.python.api.LdbMsgTests.test_contains_case
-^ldb.python.api.LdbMsgTests.test_contains_dn
-^ldb.python.api.LdbMsgTests.test_contains_dn_case
-^ldb.python.api.LdbMsgTests.test_contains_invalid