diff options
| author | Joe Guo <joeg@catalyst.net.nz> | 2017-09-15 15:31:34 +1200 |
|---|---|---|
| committer | Andrew Bartlett <abartlet@samba.org> | 2017-10-19 05:33:10 +0200 |
| commit | 8ed3cac9e558c60ab0b7e32133cea5e156ef9549 (patch) | |
| tree | 607670581491c2d78e0880a96216395c4bd8e4fa /selftest/tests.py | |
| parent | ea0cd977a3d1966f00861dc01728fe8b95b43f59 (diff) | |
| download | samba-8ed3cac9e558c60ab0b7e32133cea5e156ef9549.tar.gz | |
python: add a failed test to show Popen deadlock
`Popen.wait()` will deadlock when using stdout=PIPE and/or stderr=PIPE and the
child process generates large output to a pipe such that it blocks waiting for
the OS pipe buffer to accept more data. Use communicate() to avoid that.
This patch is commited to show the issue, a fix patch will come later.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Diffstat (limited to 'selftest/tests.py')
| -rw-r--r-- | selftest/tests.py | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/selftest/tests.py b/selftest/tests.py index 3e3ef84a5ec..639bc63649d 100644 --- a/selftest/tests.py +++ b/selftest/tests.py @@ -53,6 +53,7 @@ except ImportError: else: planpythontestsuite("none", "subunit.tests.test_suite") planpythontestsuite("none", "samba.tests.blackbox.ndrdump") +planpythontestsuite("none", "samba.tests.blackbox.check_output") planpythontestsuite("none", "api", name="ldb.python", extra_path=['lib/ldb/tests/python']) planpythontestsuite("none", "samba.tests.credentials", py3_compatible=True) planpythontestsuite("none", "samba.tests.registry", py3_compatible=True) |