diff options
author | Jeremy Allison <jra@samba.org> | 2018-07-12 12:18:50 -0700 |
---|---|---|
committer | Karolin Seeger <kseeger@samba.org> | 2018-07-28 06:16:15 +0200 |
commit | 80c7e284afadec4dc346248b1242b771b050f7da (patch) | |
tree | c327b712fe0b29aa72bc046daff04a953d58fde3 /selftest/knownfail | |
parent | a7783f5e470d6ca7d4659ba37eb558b6cc06b8a0 (diff) | |
download | samba-80c7e284afadec4dc346248b1242b771b050f7da.tar.gz |
s3: libsmbclient: Fix cli_splice() fallback when reading less than a complete file.
We were always asking for SPLICE_BLOCK_SIZE even when the
remaining bytes we wanted were smaller than that. This works
when using cli_splice() on a complete file, as the cli_read()
terminated the read at the right place. We always have the
space to read SPLICE_BLOCK_SIZE bytes so this isn't an overflow.
Found by Bailey Berro <baileyberro@google.com>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13527
Signed-off-by: Bailey Berro <baileyberro@google.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Fri Jul 13 14:57:14 CEST 2018 on sn-devel-144
(cherry picked from commit c9656fd2977557ab20ec4e3d87c385a9b2f1bf43)
Diffstat (limited to 'selftest/knownfail')
-rw-r--r-- | selftest/knownfail | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/selftest/knownfail b/selftest/knownfail index 85ed2f40abc..01b6b3aff5b 100644 --- a/selftest/knownfail +++ b/selftest/knownfail @@ -16,8 +16,6 @@ ^samba3.*rap.sam.*.useradd # Not provided by Samba 3 ^samba3.*rap.sam.*.userdelete # Not provided by Samba 3 ^samba3.libsmbclient.opendir # This requires a workgroup called 'WORKGROUP' and for netbios browse lists to have been registered -^samba3.smbtorture_s3.plain\(fileserver\).CLI_SPLICE -^samba3.smbtorture_s3.plain\(ad_dc_ntvfs\).CLI_SPLICE # see bug 8412 ^samba3.smb2.rename.*.simple_nodelete ^samba3.smb2.rename.*.no_share_delete_no_delete_access |