diff options
| author | Stefan Metzmacher <metze@samba.org> | 2018-08-17 11:35:41 +0200 |
|---|---|---|
| committer | Karolin Seeger <kseeger@samba.org> | 2018-10-10 17:25:32 +0200 |
| commit | fd017065e0178e73c9c76a0a796356e078aae77a (patch) | |
| tree | ef2383e74f38861aa8ad8197bcce0831c870a5c8 /selftest/knownfail.d | |
| parent | 5a77625fb86401f6300f3c45e2fbcaf295412ac6 (diff) | |
| download | samba-fd017065e0178e73c9c76a0a796356e078aae77a.tar.gz | |
smb2_server: set req->do_encryption = true earlier
The STATUS_SESSION_EXPIRED error was returned unencrypted,
if the request was encrypted.
If clients use SMB3 encryption and the kerberos authenticated session
expires, clients disconnect the connection instead of doing a reauthentication.
From https://blogs.msdn.microsoft.com/openspecification/2012/10/05/encryption-in-smb-3-0-a-protocol-perspective/
The sender encrypts the message if any of the following conditions is
satisfied:
- If the sender is sending a response to an encrypted request.
- If Session.EncryptData is TRUE and the request or response being
sent is not NEGOTIATE.
- If Session.EncryptData is FALSE, the request or response being sent
is not NEGOTIATE or SESSION_SETUP or TREE_CONNECT, and
<TreeConnect|Share>.EncryptData is TRUE.
[MS-SMB2] 3.3.4.1.4 Encrypting the Message
If Connection.Dialect belongs to the SMB 3.x dialect family and
Connection.ClientCapabilities includes the SMB2_GLOBAL_CAP_ENCRYPTION
bit, the server MUST encrypt the message before sending, if any of the
following conditions are satisfied:
- If the message being sent is any response to a client request for which
Request.IsEncrypted is TRUE.
- If Session.EncryptData is TRUE and the response being sent is not
SMB2_NEGOTIATE or SMB2 SESSION_SETUP.
- If Session.EncryptData is FALSE, the response being sent is not
SMB2_NEGOTIATE or SMB2 SESSION_SETUP or SMB2 TREE_CONNECT, and
Share.EncryptData for the share associated with the TreeId in the SMB2
header of the response is TRUE.
The server MUST encrypt the message as specified in section 3.1.4.3,
before sending it to the client.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13624
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Tue Oct 2 14:11:30 CEST 2018 on sn-devel-144
(cherry picked from commit 4ef45e5334d5874f5d0fdc69286b745ebcdc612d)
Autobuild-User(v4-8-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-8-test): Wed Oct 10 17:25:32 CEST 2018 on sn-devel-144
Diffstat (limited to 'selftest/knownfail.d')
| -rw-r--r-- | selftest/knownfail.d/session-expire | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/selftest/knownfail.d/session-expire b/selftest/knownfail.d/session-expire deleted file mode 100644 index 033564afb58..00000000000 --- a/selftest/knownfail.d/session-expire +++ /dev/null @@ -1,2 +0,0 @@ -^samba3.smb2.session krb5.expire1e -^samba3.smb2.session krb5.expire2e |