diff options
| author | Björn Baumbach <bb@sernet.de> | 2018-09-05 16:54:01 +0200 |
|---|---|---|
| committer | Björn Baumbach <bb@sernet.de> | 2018-09-12 18:03:10 +0200 |
| commit | cc30805e5c57a4440dc318a6a25c8c80cde0cef7 (patch) | |
| tree | c0065279e9b9541a563f2da4db5a909fd817c1b7 /selftest/knownfail.d/dns | |
| parent | 3903f6c365014af804066f916a27fa6d886846e3 (diff) | |
| download | samba-cc30805e5c57a4440dc318a6a25c8c80cde0cef7.tar.gz | |
samba_dnsupdate: honor 'dns zone scavenging' option, only update if needed
Since scavenging is implemented the samba_dnsupdate command always updates all
dns records required by the dc. This is not needed if dns zone scavenging
is not enabled.
This avoids the repeating TSIG error messages:
# samba_dnsupdate --option='dns zone scavenging = yes' 2>&1 | uniq -c
29 ; TSIG error with server: tsig verify failure
1 Failed update of 29 entries
# echo ${PIPESTATUS[0]}
29
# samba_dnsupdate --option='dns zone scavenging = no' 2>&1 | uniq -c
# echo ${PIPESTATUS[0]}
0
Note that this results in about 60 lines in the log file,
which triggered every 10 minutes ("dnsupdate:name interval=600" is the default).
This restores the behavior before 8ef42d4dab4dfaf5ad225b33f7748914f14dcd8c,
if "dns zone scavenging" is not switched on (which is still the default).
Avoiding the message from happening at all is subject for more debugging,
most likely they are caused by bugs in 'nsupdate -g' (from the bind package).
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13605
Pair-programmed-with: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Björn Baumbach <bb@sernet.de>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Björn Baumbach <bb@sernet.de>
Autobuild-Date(master): Wed Sep 12 18:03:10 CEST 2018 on sn-devel-144
Diffstat (limited to 'selftest/knownfail.d/dns')
| -rw-r--r-- | selftest/knownfail.d/dns | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/selftest/knownfail.d/dns b/selftest/knownfail.d/dns index d23f5ebe21c..ca18b4334c1 100644 --- a/selftest/knownfail.d/dns +++ b/selftest/knownfail.d/dns @@ -70,5 +70,3 @@ samba.tests.dns.__main__.TestSimpleQueries.test_qtype_all_query\(rodc:local\) # The SOA override should not pass against the RODC, it must not overstamp samba.tests.dns.__main__.TestSimpleQueries.test_one_SOA_query\(rodc:local\) -.*samba.tests.blackbox.samba_dnsupdate.SambaDnsUpdateTests.test_samba_dnsupate_set_ip -.*samba.tests.blackbox.samba_dnsupdate.SambaDnsUpdateTests.test_samba_dnsupate_no_change |