diff options
| author | Tim Beale <timbeale@catalyst.net.nz> | 2018-08-09 15:34:51 +1200 |
|---|---|---|
| committer | Karolin Seeger <kseeger@samba.org> | 2018-08-23 10:39:15 +0200 |
| commit | 15e1a41130281ff32e727e2aafef37cfc7816e5a (patch) | |
| tree | 5d926c7ac33507cb5e75d61f47bab610cb9ae4a9 /python | |
| parent | 69583d1d32e01472b52543a730af63a99ef9c3f6 (diff) | |
| download | samba-15e1a41130281ff32e727e2aafef37cfc7816e5a.tar.gz | |
netcmd: Fix kerberos option for domain backups
The previous fix still didn't work if you specified --kerberos=yes (in
which case the creds still doesn't have a password).
credopts.get_credentials(lp) should be enough to ensure a user/password
is set (it's all that the other commands seem to do).
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13566
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
(cherry picked from commit 8fb706c34682bf6dc6033963518c7eccffc3944f)
Diffstat (limited to 'python')
| -rw-r--r-- | python/samba/netcmd/domain_backup.py | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/python/samba/netcmd/domain_backup.py b/python/samba/netcmd/domain_backup.py index b16763afb15..b2c830259fc 100644 --- a/python/samba/netcmd/domain_backup.py +++ b/python/samba/netcmd/domain_backup.py @@ -152,10 +152,6 @@ def check_targetdir(logger, targetdir): def check_online_backup_args(logger, creds, server, targetdir): # Make sure we have all the required args. - u_p = {'user': creds.get_username(), - 'pass': creds.get_password()} - if None in u_p.values(): - raise CommandError("Creds required.") if server is None: raise CommandError('Server required') |