diff options
| author | Björn Jacke <bj@sernet.de> | 2020-01-03 15:29:34 +0100 |
|---|---|---|
| committer | Bjoern Jacke <bjacke@samba.org> | 2020-01-03 22:19:47 +0000 |
| commit | 03b42aeb811ae7260a9a9e197212767877484a78 (patch) | |
| tree | 4deb121219ae4687eb8cba9fe08fb11d3b4bcb5f /python | |
| parent | 4d4443d1e539c1ce0f7245fbcffbf22df8355b2d (diff) | |
| download | samba-03b42aeb811ae7260a9a9e197212767877484a78.tar.gz | |
python/loadparm: check for AD DC required VFS modules
same as the previous commit, just for python's testparm code
Bug: https://bugzilla.samba.org/show_bug.cgi?id=10560
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): Björn Jacke <bjacke@samba.org>
Autobuild-Date(master): Fri Jan 3 22:19:47 UTC 2020 on sn-devel-184
Diffstat (limited to 'python')
| -rw-r--r-- | python/samba/netcmd/testparm.py | 18 |
1 files changed, 13 insertions, 5 deletions
diff --git a/python/samba/netcmd/testparm.py b/python/samba/netcmd/testparm.py index bf566f38d78..aef24bf5c8d 100644 --- a/python/samba/netcmd/testparm.py +++ b/python/samba/netcmd/testparm.py @@ -157,12 +157,20 @@ class cmd_testparm(Command): valid = False role = lp.get("server role") - charset = lp.get("unix charset").upper() - if role in ["active directory domain controller", "domain controller", "dc"] and charset not in ["UTF-8", "UTF8"]: - logger.warning( - "When acting as Active Directory domain controller, " - "unix charset is expected to be UTF-8.") + if role in ["active directory domain controller", "domain controller", "dc"]: + charset = lp.get("unix charset").upper() + if charset not in ["UTF-8", "UTF8"]: + logger.warning( + "When acting as Active Directory domain controller, " + "unix charset is expected to be UTF-8.") + vfsobjects = lp.get("vfs objects") + if vfsobjects: + for entry in ['dfs_samba4', 'acl_xattr']: + if entry not in vfsobjects: + logger.warning( + "When acting as Active Directory domain controller, " + + entry + " should be in vfs objects.") return valid |