diff options
author | Tim Beale <timbeale@catalyst.net.nz> | 2018-11-20 10:59:40 +1300 |
---|---|---|
committer | Tim Beale <timbeale@samba.org> | 2018-11-21 05:31:10 +0100 |
commit | a370f217bb94601345ad5700ea546259e1d04bfd (patch) | |
tree | ff4c81b75510a2637660ff6b46460d215b9a3fc2 /python | |
parent | 05147d25e7b4a9343378c59927f443b723606960 (diff) | |
download | samba-a370f217bb94601345ad5700ea546259e1d04bfd.tar.gz |
replmd: Make replmd_process_linked_attribute() mem dependencies clearer
This patch should not alter functionality - it is just making memory
assumptions used in replmd_process_linked_attribute() clearer.
When adding/removing msg->elements we have to take care, as this will
invalidate things like the parsed-DN array or old ldb_message_element
pointers. This has always been the case (i.e. f6bc4c08b19f5615a49),
however, now we need to take even more care, as the msg being modified
is re-used and split across 2 different functions.
Add more code comments to highlight this. We can also free
pdn_list/old_el to prevent them being incorrectly used after realloc.
It seems appropriate to also add a sanity-check that the tmp_ctx alloc
succeeds (which all the other memory hangs off).
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Tim Beale <timbeale@samba.org>
Autobuild-Date(master): Wed Nov 21 05:31:10 CET 2018 on sn-devel-144
Diffstat (limited to 'python')
0 files changed, 0 insertions, 0 deletions