summaryrefslogtreecommitdiff
path: root/nsswitch
diff options
context:
space:
mode:
authorGünther Deschner <gd@samba.org>2020-03-27 10:13:11 +0100
committerKarolin Seeger <kseeger@samba.org>2020-03-31 16:14:54 +0000
commit16d837cb233fca641943d0194a3e0cb379275ec4 (patch)
tree84f09cdd9c877701bfa95c5b0a4cb93aa3346853 /nsswitch
parent8159513ac73839a249a8adb059be9dbea9a57681 (diff)
downloadsamba-16d837cb233fca641943d0194a3e0cb379275ec4.tar.gz
nsswitch: fix use-after-free causing segfault in _pam_delete_cred
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14327 Guenther Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-by: Alexander Bokovoy <ab@samba.org> Autobuild-User(master): Günther Deschner <gd@samba.org> Autobuild-Date(master): Mon Mar 30 13:01:20 UTC 2020 on sn-devel-184 (cherry picked from commit 047b0d8ab534c7a10a8572fd9f21e2456fd30710) Autobuild-User(v4-11-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-11-test): Tue Mar 31 16:14:54 UTC 2020 on sn-devel-184
Diffstat (limited to 'nsswitch')
-rw-r--r--nsswitch/pam_winbind.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/nsswitch/pam_winbind.c b/nsswitch/pam_winbind.c
index 3ad70d3c4cd..7af03fe2bd0 100644
--- a/nsswitch/pam_winbind.c
+++ b/nsswitch/pam_winbind.c
@@ -2609,7 +2609,6 @@ static int _pam_delete_cred(pam_handle_t *pamh, int flags,
wbc_status = wbcCtxLogoffUserEx(ctx->wbc_ctx, &logoff, &error);
retval = wbc_auth_error_to_pam_error(ctx, error, wbc_status,
user, "wbcLogoffUser");
- wbcFreeMemory(error);
wbcFreeMemory(logoff.blobs);
logoff.blobs = NULL;
@@ -2629,6 +2628,7 @@ out:
retval = wbc_auth_error_to_pam_error(ctx, error, wbc_status,
user, "wbcLogoffUser");
}
+ wbcFreeMemory(error);
/*
* Delete the krb5 ccname variable from the PAM environment