summaryrefslogtreecommitdiff
path: root/librpc/idl/netlogon.idl
diff options
context:
space:
mode:
authorStefan Metzmacher <metze@samba.org>2016-07-14 09:34:43 +0200
committerStefan Metzmacher <metze@samba.org>2016-07-20 21:27:19 +0200
commit0e201ecdc53b07d66342e453b3710d3d06481b8b (patch)
tree4ac9821b0e97c735fe46986754b63f1c295d86c1 /librpc/idl/netlogon.idl
parenta6f672d69f9bb3933181f45bbd51f4014224bdca (diff)
downloadsamba-0e201ecdc53b07d66342e453b3710d3d06481b8b.tar.gz
krb5pac/netlogon: add a comment regarding PAC_LOGON_INFO unique pointers on push
This difference is the reason why we can't fully (ndr)validate some PAC blobs. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
Diffstat (limited to 'librpc/idl/netlogon.idl')
-rw-r--r--librpc/idl/netlogon.idl8
1 files changed, 8 insertions, 0 deletions
diff --git a/librpc/idl/netlogon.idl b/librpc/idl/netlogon.idl
index 5eb8e6ae236..621d537a62c 100644
--- a/librpc/idl/netlogon.idl
+++ b/librpc/idl/netlogon.idl
@@ -263,6 +263,14 @@ interface netlogon
netr_SamBaseInfo base;
uint32 sidcount;
[size_is(sidcount)] netr_SidAttr *sids;
+ /*
+ * On ndr_push:
+ * Should pointer values be allocated
+ * of sids[*].sid before the following ones?
+ *
+ * That's at least the case for
+ * PAC_LOGON_INFO.
+ */
lsa_String dns_domainname;
lsa_String principal_name;
uint32 unknown4[20];