diff options
| author | Volker Lendecke <vl@samba.org> | 2015-01-02 11:02:45 +0100 |
|---|---|---|
| committer | Jeremy Allison <jra@samba.org> | 2015-04-28 18:11:13 +0200 |
| commit | b2c34d45c0b16a8e7acff864b8c5fdca9f38d20d (patch) | |
| tree | c45b6d582a3e633303956f231362aad506927fe0 /libcli | |
| parent | 78f43ed5a751ccf5cf03093a9515615543694de7 (diff) | |
| download | samba-b2c34d45c0b16a8e7acff864b8c5fdca9f38d20d.tar.gz | |
lib: Simplify dom_sid_parse_length
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Diffstat (limited to 'libcli')
| -rw-r--r-- | libcli/security/dom_sid.c | 11 |
1 files changed, 3 insertions, 8 deletions
diff --git a/libcli/security/dom_sid.c b/libcli/security/dom_sid.c index 836979e4509..291043446b0 100644 --- a/libcli/security/dom_sid.c +++ b/libcli/security/dom_sid.c @@ -243,14 +243,9 @@ struct dom_sid *dom_sid_parse_talloc(TALLOC_CTX *mem_ctx, const char *sidstr) */ struct dom_sid *dom_sid_parse_length(TALLOC_CTX *mem_ctx, const DATA_BLOB *sid) { - struct dom_sid *ret; - char *p = talloc_strndup(mem_ctx, (char *)sid->data, sid->length); - if (!p) { - return NULL; - } - ret = dom_sid_parse_talloc(mem_ctx, p); - talloc_free(p); - return ret; + char p[sid->length+1]; + memcpy(p, sid->data, sizeof(p)); + return dom_sid_parse_talloc(mem_ctx, p); } /* |