summaryrefslogtreecommitdiff
path: root/libcli
diff options
context:
space:
mode:
authorJoseph Sutton <josephsutton@catalyst.net.nz>2022-03-14 18:14:15 +1300
committerJoseph Sutton <jsutton@samba.org>2022-03-17 23:11:37 +0000
commite61fa573fe1a911460cfb3b64ba05b031d124256 (patch)
tree58064ea2fbc2cd34e2f62afa526ebc643bbd5946 /libcli
parent9b913fcb0f4e69b9fd7db1c974d7534ef356a318 (diff)
downloadsamba-e61fa573fe1a911460cfb3b64ba05b031d124256.tar.gz
sddl: Fix incorrect SDDL SID strings
Change the values to match those used by Windows. Verified with PowerShell commands of the form: New-Object Security.Principal.SecurityIdentifier ER Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz> Reviewed-by: Stefan Metzmacher <metze@samba.org>
Diffstat (limited to 'libcli')
-rw-r--r--libcli/security/sddl.c8
1 files changed, 5 insertions, 3 deletions
diff --git a/libcli/security/sddl.c b/libcli/security/sddl.c
index 26049ec458a..046a9284f5e 100644
--- a/libcli/security/sddl.c
+++ b/libcli/security/sddl.c
@@ -104,7 +104,6 @@ static const struct {
{ .code = "SY", .sid = SID_NT_SYSTEM },
{ .code = "LS", .sid = SID_NT_LOCAL_SERVICE },
{ .code = "NS", .sid = SID_NT_NETWORK_SERVICE },
- { .code = "IS", .sid = SID_NT_IUSR },
{ .code = "BA", .sid = SID_BUILTIN_ADMINISTRATORS },
{ .code = "BU", .sid = SID_BUILTIN_USERS },
@@ -121,11 +120,15 @@ static const struct {
{ .code = "NO", .sid = SID_BUILTIN_NETWORK_CONF_OPERATORS },
{ .code = "IF", .sid = SID_BUILTIN_INCOMING_FOREST_TRUST },
+ { .code = "IS", .sid = SID_BUILTIN_IUSERS },
+ { .code = "ER", .sid = SID_BUILTIN_EVENT_LOG_READERS },
+
+ { .code = "RO", .sid = NULL, .rid = DOMAIN_RID_ENTERPRISE_READONLY_DCS },
+
{ .code = "LA", .sid = NULL, .rid = DOMAIN_RID_ADMINISTRATOR },
{ .code = "LG", .sid = NULL, .rid = DOMAIN_RID_GUEST },
{ .code = "LK", .sid = NULL, .rid = DOMAIN_RID_KRBTGT },
- { .code = "ER", .sid = NULL, .rid = DOMAIN_RID_ENTERPRISE_READONLY_DCS },
{ .code = "DA", .sid = NULL, .rid = DOMAIN_RID_ADMINS },
{ .code = "DU", .sid = NULL, .rid = DOMAIN_RID_USERS },
{ .code = "DG", .sid = NULL, .rid = DOMAIN_RID_GUESTS },
@@ -135,7 +138,6 @@ static const struct {
{ .code = "SA", .sid = NULL, .rid = DOMAIN_RID_SCHEMA_ADMINS },
{ .code = "EA", .sid = NULL, .rid = DOMAIN_RID_ENTERPRISE_ADMINS },
{ .code = "PA", .sid = NULL, .rid = DOMAIN_RID_POLICY_ADMINS },
- { .code = "RO", .sid = NULL, .rid = DOMAIN_RID_READONLY_DCS },
{ .code = "RS", .sid = NULL, .rid = DOMAIN_RID_RAS_SERVERS }
};